> On May 2, 2014, 5:51 p.m., Neha Narkhede wrote: > > core/src/main/scala/kafka/producer/TransitProducer.scala, lines 24-25 > > <https://reviews.apache.org/r/20997/diff/1/?file=573268#file573268line24> > > > > +1 on renaming this as per Jun's suggestion. > > > > If this is only for the tools, then let's move it to the tools package.
ConsoleProducer is in kafka.producer ProducerPerformance is in kafka.perf MirrorMaker is in kafka.tools So I decided to put the BaseProducer in kafka.producer. Let me know if you have another preference. > On May 2, 2014, 5:51 p.m., Neha Narkhede wrote: > > core/src/main/scala/kafka/producer/ConsoleProducer.scala, line 50 > > <https://reviews.apache.org/r/20997/diff/1/?file=573267#file573267line50> > > > > It will be cleaner to move this logic into a buildProducerConfig > > private API that builds either the new or old producer's configs based on > > some boolean value. The thing is that this buildProducerConfig would not be able to be shared between ConsoleProducer and ProducerPerformance since the former used its own ProducerConfig while the latter used its own ProducerPerfConfig. So we would have two buildProducerConfig functions in these two classes and just move the logic there. I think it would not help much for the cleaning. - Guozhang ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20997/#review42028 ----------------------------------------------------------- On May 1, 2014, 11:46 p.m., Guozhang Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20997/ > ----------------------------------------------------------- > > (Updated May 1, 2014, 11:46 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1432 > https://issues.apache.org/jira/browse/KAFKA-1432 > > > Repository: kafka > > > Description > ------- > > 1. Add useNewProducer in the MirrorMaker. > 2. Remove MirrorMaker's dependency on MigrationTool's producer thread and > data channel. > 3. Unify Old/New Producer in a new class for MirrorMaker, ProducerPerformance > and ConsoleProducer > > Will remove kafka.tools.newproducer.MirrorMaker upon final commit. > > > Diffs > ----- > > core/src/main/scala/kafka/producer/ByteArrayPartitioner.scala > 988e4374d8c9b30c9333369741c30c75f0c44f2c > core/src/main/scala/kafka/producer/ConsoleProducer.scala > b19ab49c5fd57423e142f2f8afc5a77e653fd6ed > core/src/main/scala/kafka/producer/TransitProducer.scala PRE-CREATION > core/src/main/scala/kafka/tools/MirrorMaker.scala > e4d1a86f673f7df7fe71ce44e3550fcde8d01bba > perf/src/main/scala/kafka/perf/ProducerPerformance.scala > 1490bdb3d52d5c901d7a464222284935bda2f7ca > > Diff: https://reviews.apache.org/r/20997/diff/ > > > Testing > ------- > > > Thanks, > > Guozhang Wang > >
