Hi Mohamed, Thank you for the KIP.
Comments regarding the KIP wiki: 1. In section "Public Interface", you should state what you want to change in interface StreamsMetrics. In your case, you want to add two methods. You can find a good example how to describe this in KIP-444 (https://cwiki.apache.org/confluence/display/KAFKA/KIP-444%3A+Augment+metrics+for+Kafka+Streams). 2. In section "Compatibility, Deprecation, and Migration Plan" you should state if anything is needed to keep backward compatibility. Since you just want to add two methods to the interface, nothing is needed. You should describe that under that section. Regarding the KIP content, I left some comments on the corresponding Jira ticket. Best, Bruno On Sun, Jul 5, 2020 at 3:48 AM Mohamed Chebbi <mhmdche...@gmail.com> wrote: > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-639%3A+Move+nodeLevelSensor+and+storeLevelSensor+methods+from+StreamsMetricsImpl+to+StreamsMetrics >