scott-confluent commented on a change in pull request #284:
URL: https://github.com/apache/kafka-site/pull/284#discussion_r466554238
##########
File path: includes/_footer.htm
##########
@@ -329,7 +329,13 @@
var docsHandle =
document.querySelector('.toc-handle');
function toggleDocsWidth() {
-
docsContainer.classList.toggle('expanded');
+ let isExpanded =
docsContainer.classList.toggle('expanded');
+ // change the arrow direction based on
the view state is expanded or not
+ if (isExpanded) {
Review comment:
This is technically only working because JavaScript is lax on types and
the `DOMTokenList` returned by `classList.toggle` is empty resulting in a
falsy value. We should probably do `isExapnded.contains('expanded')` as the
condition to be more explicit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
