A bit late on this thread, but I've reviewed the KIP and I'm also +1. Thanks Tom. Happy to see this improvement making it in.
Konstantine On Thu, Aug 6, 2020 at 10:27 AM Tom Bentley <tbent...@redhat.com> wrote: > With 3 binding +1 (Manikumar, Mickael and Rajini) and 2 non-binding +1 > (David and William) the vote passes. > > Thanks to all who voted. > > Tom > > On Thu, Aug 6, 2020 at 12:39 PM Rajini Sivaram <rajinisiva...@gmail.com> > wrote: > > > Hi Tom, > > > > +1 (binding) > > > > Thanks for the KIP. Apart from being useful when using frameworks like > > Kubernetes, it also seems like a neater way of storing complex > > multi-line configs without embedding into a property file. > > > > Regards, > > > > Rajini > > > > > > On Thu, Aug 6, 2020 at 12:29 PM William Reynolds < > > william.reyno...@instaclustr.com> wrote: > > > > > +1 (non binding) Looks like a good addition! > > > > > > On 06/08/2020, Tom Bentley <tbent...@redhat.com> wrote: > > > > This pretty minor change has 2 binding and 1 non-binding votes. It > > would > > > be > > > > great if more people could take a look and either vote or give > feedback > > > > about how it should be improved. > > > > > > > > Many thanks, > > > > > > > > Tom > > > > > > > > On Wed, Jul 8, 2020 at 7:07 PM Mickael Maison < > > mickael.mai...@gmail.com> > > > > wrote: > > > > > > > >> +1 (binding) > > > >> Thanks > > > >> > > > >> On Wed, Jul 8, 2020 at 11:31 AM Manikumar < > manikumar.re...@gmail.com> > > > >> wrote: > > > >> > > > > >> > +1 (bindig) > > > >> > > > > >> > Thanks for the KIP. > > > >> > > > > >> > On Tue, Jul 7, 2020 at 10:30 PM David Jacot <dja...@confluent.io> > > > >> > wrote: > > > >> > > > > >> > > +1 (non-binding). Thanks for the KIP! > > > >> > > > > > >> > > On Tue, Jul 7, 2020 at 12:54 PM Tom Bentley < > tbent...@redhat.com> > > > >> wrote: > > > >> > > > > > >> > > > Hi, > > > >> > > > > > > >> > > > I'd like to start a vote on KIP-632, which is about making the > > > >> > > > config > > > >> > > > provider mechanism more ergonomic on Kubernetes: > > > >> > > > > > > >> > > > > > > >> > > > > > > >> > > > > > >> > > > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-632%3A+Add+DirectoryConfigProvider > > > >> > > > > > > >> > > > Please take a look if you have time. > > > >> > > > > > > >> > > > Many thanks, > > > >> > > > > > > >> > > > Tom > > > >> > > > > > > >> > > > > > >> > > > >> > > > > > > > > > > > > > -- > > > > > > > > > > > > *William Reynolds**Technical Operations Engineer* > > > > > > > > > <https://www.facebook.com/instaclustr> < > > https://twitter.com/instaclustr> > > > <https://www.linkedin.com/company/instaclustr> > > > > > > Read our latest technical blog posts here > > > <https://www.instaclustr.com/blog/>. > > > > > > This email has been sent on behalf of Instaclustr Pty. Limited > > (Australia) > > > and Instaclustr Inc (USA). > > > > > > This email and any attachments may contain confidential and legally > > > privileged information. If you are not the intended recipient, do not > > copy > > > or disclose its content, but please reply to this email immediately and > > > highlight the error to the sender and then immediately delete the > > message. > > > > > > Instaclustr values your privacy. Our privacy policy can be found at > > > https://www.instaclustr.com/company/policies/privacy-policy > > > > > >
