Hi Anastasia, Thanks for the KIP, I can certainly see the benefit of this. I have a few questions:
1. I think it would be helpful to readers to explicitly illustrate the RequestConvertToJson and XYZJsonDataConverter classes (e.g. with method signatures for one or two methods), because currently it's not clear (to me at least) exactly what's being proposed. Does the RequestConvertToJson return a XYZJsonDataConverter? 2. Does the serialization have a defined order of properties (alphabetic perhaps)? My concern here is that properties appearing in order according to how they are iterated in a hash map might harm human readability of the logs. 3. Would the serialization be done via the Jackson databinding? Many thanks, Tom On Thu, Sep 24, 2020 at 11:49 PM Anastasia Vela <av...@confluent.io> wrote: > Hi all, > > I'd like to discuss KIP-673: > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-673%3A+Emit+JSONs+with+new+auto-generated+schema > > This is a proposal to change the format of request and response traces to > JSON, which would be easier to load and parse, because the current format > is only JSON-like and not easily parsable. > > Let me know what you think, > Anastasia >
