> On May 22, 2014, 9:14 p.m., Neha Narkhede wrote: > > Thanks. Do we also need to do the same for PartitonMetadata, as the JIRA > > indicates? > > Sriharsha Chintalapani wrote: > Yes its included in the TopicMetadata.scala line 74. >
Oh yes, somehow missed it :) - Neha ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21712/#review43774 ----------------------------------------------------------- On May 20, 2014, 5:06 p.m., Sriharsha Chintalapani wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21712/ > ----------------------------------------------------------- > > (Updated May 20, 2014, 5:06 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1444 > https://issues.apache.org/jira/browse/KAFKA-1444 > > > Repository: kafka > > > Description > ------- > > KAFKA-1444. kafka.javaapi.TopicMetadata and PartitionMetadata doesn't forward > the toString method. > > > Diffs > ----- > > core/src/main/scala/kafka/javaapi/TopicMetadata.scala > d08c3f4af51e742ac441e65c97d547f097c169ca > core/src/main/scala/kafka/javaapi/TopicMetadataResponse.scala > 252a0c9d6c12b5e79426b7eca85ab0bb067b42b0 > > Diff: https://reviews.apache.org/r/21712/diff/ > > > Testing > ------- > > > Thanks, > > Sriharsha Chintalapani > >
