Sorry I missed the discussion, but I just read the KIP and the discussion. It all looks good to me.
+1 (binding) -John On Thu, 2020-12-03 at 14:00 -0700, Matthias J. Sax wrote: > +1 (binding) > > On 12/3/20 11:21 AM, Guozhang Wang wrote: > > +1 (binding) > > > > Thanks Leah! > > > > On Wed, Dec 2, 2020 at 11:27 AM Sophie Blee-Goldman <sop...@confluent.io> > > wrote: > > > > > Thanks for the KIP! +1 (binding) > > > > > > Sophie > > > > > > On Wed, Dec 2, 2020 at 8:42 AM Walker Carlson <wcarl...@confluent.io> > > > wrote: > > > > > > > +1 (non-binding) > > > > > > > > Thank you, > > > > walker > > > > > > > > On Wed, Dec 2, 2020 at 8:15 AM Bruno Cadonna <br...@confluent.io> wrote: > > > > > > > > > +1 (non-binding) > > > > > > > > > > Thanks Leah! > > > > > > > > > > Best, > > > > > Bruno > > > > > > > > > > On 02.12.20 16:55, Leah Thomas wrote: > > > > > > Hi all, > > > > > > > > > > > > I'd like to start the vote for KIP-689 for enabling/disabling > > > > > > logging > > > > for > > > > > > `StreamJoined`. > > > > > > > > > > > > > > > > > > > > > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-689%3A+Extend+%60StreamJoined%60+to+allow+more+store+configs > > > > > > > > > > > > Thanks, > > > > > > Leah > > > > > > > > > > > > > > > > > > > > > >
