----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21272/#review44790 -----------------------------------------------------------
core/src/main/scala/kafka/admin/DeleteTopicCommand.scala <https://reviews.apache.org/r/21272/#comment79327> Do we need DeleteTopicCommand if we are adding the --delete option to the kafka-topics tool? I guess we could just get rid of DeleteTopicCommand and stick to TopicCommand - Neha Narkhede On May 9, 2014, 5:59 p.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21272/ > ----------------------------------------------------------- > > (Updated May 9, 2014, 5:59 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1443 > https://issues.apache.org/jira/browse/KAFKA-1443 > > > Repository: kafka > > > Description > ------- > > Add delete topic option to topic commands > > > Diffs > ----- > > core/src/main/scala/kafka/admin/DeleteTopicCommand.scala > 804b331a7e4418219bc21ec920b98a0c3a21fac9 > core/src/main/scala/kafka/admin/TopicCommand.scala > bdc72eaa9052b6f46bac510ab53c57d3283cdc25 > > Diff: https://reviews.apache.org/r/21272/diff/ > > > Testing > ------- > > > Thanks, > > Timothy Chen > >