> On June 6, 2014, 5:14 p.m., Guozhang Wang wrote: > > clients/src/main/java/org/apache/kafka/clients/NetworkClient.java, line 93 > > <https://reviews.apache.org/r/21937/diff/3/?file=603194#file603194line93> > > > > Maybe rename to getReady()?
It isn't a getter. It actually is something more like boolean becomeReady(node) I think of the usage in the same way you would say "Ready the lifeboats!". Alternately we could break this up and have it be something like if(client.isReady(node)) client.poll(...) else client.makeReady(node) I guess the only argument for the current approach is that there isn't much point in checking readiness unless you also intend to make it ready... > On June 6, 2014, 5:14 p.m., Guozhang Wang wrote: > > clients/src/main/java/org/apache/kafka/clients/NetworkClient.java, line 158 > > <https://reviews.apache.org/r/21937/diff/3/?file=603194#file603194line158> > > > > numInFlightRequests()? Changed to inFlightRequestCount(), good? > On June 6, 2014, 5:14 p.m., Guozhang Wang wrote: > > clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java, > > line 490 > > <https://reviews.apache.org/r/21937/diff/3/?file=603197#file603197line490> > > > > I made now to nowMs since we have both MilliSec and NanoSec in the > > producer used in metrics, and I felt it is better to indicate that which > > values are for Milli and which are for Nano. Yeah that makes sense. We have always had the convention on the server-side as well as other projects of using now to be the current time in milliseconds. So I had kept that and differentiated nowNs. I think it is kind of nice to have a short three letter variable for the current time. Either way is probably fine but it should probably be consistent... - Jay ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21937/#review44921 ----------------------------------------------------------- On June 3, 2014, 9:33 p.m., Jay Kreps wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21937/ > ----------------------------------------------------------- > > (Updated June 3, 2014, 9:33 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1316 > https://issues.apache.org/jira/browse/KAFKA-1316 > > > Repository: kafka > > > Description > ------- > > KAFKA-1316 Refactor a reusable NetworkClient interface out of Sender. > > > Diffs > ----- > > clients/src/main/java/org/apache/kafka/clients/ClientRequest.java > PRE-CREATION > clients/src/main/java/org/apache/kafka/clients/ClientResponse.java > PRE-CREATION > clients/src/main/java/org/apache/kafka/clients/ClusterConnectionStates.java > PRE-CREATION > clients/src/main/java/org/apache/kafka/clients/ConnectionState.java > PRE-CREATION > clients/src/main/java/org/apache/kafka/clients/InFlightRequests.java > PRE-CREATION > clients/src/main/java/org/apache/kafka/clients/KafkaClient.java > PRE-CREATION > clients/src/main/java/org/apache/kafka/clients/NetworkClient.java > PRE-CREATION > clients/src/main/java/org/apache/kafka/clients/NodeConnectionState.java > PRE-CREATION > clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java > d15562a968d9e4b08f26b8d30986881adfe29e31 > > clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java > 9b1f5653548ba90defdae43940a5554066770b0a > clients/src/main/java/org/apache/kafka/common/network/Selector.java > 3e358985ed72a894a71d683acc7460695d6f2056 > clients/src/main/java/org/apache/kafka/common/protocol/types/Schema.java > 68b8827f3bdd64580e1b443fce5b8c63152dd94a > clients/src/main/java/org/apache/kafka/common/record/MemoryRecords.java > 428968cd38a7b12991f87868bf759926ff7e594e > clients/src/main/java/org/apache/kafka/common/requests/ProduceRequest.java > PRE-CREATION > clients/src/main/java/org/apache/kafka/common/requests/ProduceResponse.java > 6fa4a58f5f9792776a647e8f682d7faadc0d1556 > clients/src/test/java/org/apache/kafka/clients/MockClient.java PRE-CREATION > clients/src/test/java/org/apache/kafka/clients/NetworkClientTest.java > PRE-CREATION > > clients/src/test/java/org/apache/kafka/clients/producer/RecordAccumulatorTest.java > c4072ae90fb58101a67f83054fbe0b8349e71c2e > clients/src/test/java/org/apache/kafka/clients/producer/SenderTest.java > 3ef692ca3e9fb83868a9da6f30c0705bb3d0aed2 > clients/src/test/java/org/apache/kafka/common/utils/MockTime.java > cda8e644587aad9a8c9c96c222edc1ba27de1fb0 > core/src/test/scala/integration/kafka/api/ProducerFailureHandlingTest.scala > cd4ca2fa77763b090c6ad4ba4a5d46a6a8b76698 > > Diff: https://reviews.apache.org/r/21937/diff/ > > > Testing > ------- > > > Thanks, > > Jay Kreps > >
