showuon commented on a change in pull request #361:
URL: https://github.com/apache/kafka-site/pull/361#discussion_r658532684
##########
File path: 27/streams/developer-guide/memory-mgmt.html
##########
@@ -179,7 +179,7 @@ <h2><a class="toc-backref" href="#id3">RocksDB</a><a
class="headerlink" href="#r
<span class="nd">@Override</span>
<span class="kd">public</span> <span class="kt">void</span> <span
class="nf">setConfig</span><span class="o">(</span><span
class="kd">final</span> <span class="n">String</span> <span
class="n">storeName</span><span class="o">,</span> <span
class="kd">final</span> <span class="n">Options</span> <span
class="n">options</span><span class="o">,</span> <span class="kd">final</span>
<span class="n">Map</span><span class="o"><</span><span
class="n">String</span><span class="o">,</span> <span
class="n">Object</span><span class="o">></span> <span
class="n">configs</span><span class="o">)</span> <span class="o">{</span>
- <span class="n">BlockBasedTableConfig</span> <span
class="n">tableConfig</span> <span class="o">=</span> <span
class="k">(BlockBasedTableConfig)</span> <span
class="n">options</span><span><span class="o">.</span><span
class="na">tableFormatConfig</span><span class="o">();</span>
+ <span class="n">BlockBasedTableConfig</span> <span
class="n">tableConfig</span> <span class="o">=</span> <span
class="k">(BlockBasedTableConfig)</span> <span class="n">options</span><span
class="o">.</span><span class="na">tableFormatConfig</span><span
class="o">();</span>
Review comment:
fix 2: remove redundant `span` tag
##########
File path: 27/streams/developer-guide/memory-mgmt.html
##########
@@ -201,6 +201,7 @@ <h2><a class="toc-backref" href="#id3">RocksDB</a><a
class="headerlink" href="#r
<span class="c1">// Cache and WriteBufferManager should not be closed
here, as the same objects are shared by every store instance.</span>
<span class="o">}</span>
<span class="o">}</span>
+ </pre>
Review comment:
fix 1: add missing `pre` tag
##########
File path: 27/streams/developer-guide/memory-mgmt.html
##########
@@ -217,6 +218,7 @@ <h2><a class="toc-backref" href="#id3">RocksDB</a><a
class="headerlink" href="#r
In addition to the recommended configs above, you may want to
consider using partitioned index filters as described by the <a
class="reference external"
href="https://github.com/facebook/rocksdb/wiki/Partitioned-Index-Filters";>RocksDB
docs</a>.
</dl>
+ </sup>
Review comment:
add missing `sup` tag
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
