A. Sophie Blee-Goldman created KAFKA-13075:
----------------------------------------------
Summary: Consolidate RocksDBStore and RocksDBKeyValueStoreTest
Key: KAFKA-13075
URL: https://issues.apache.org/jira/browse/KAFKA-13075
Project: Kafka
Issue Type: Improvement
Components: streams
Reporter: A. Sophie Blee-Goldman
Looks like we have two different test classes covering pretty much the same
thing: RocksDBStore. It seems like RocksDBKeyValueStoreTest was the original
test class for RocksDBStore, but someone later added RocksDBStoreTest, most
likely because they didn't notice the RocksDBKeyValueStoreTest which didn't
follow the usual naming scheme for test classes.
We should consolidate these two into a single file, ideally retaining the
RocksDBStoreTest name since that conforms to the test naming pattern used
throughout Streams (and so this same thing doesn't happen again). It should
also extend AbstractKeyValueStoreTest like the RocksDBKeyValueStoreTest
currently does so we continue to get the benefit of all the tests in there as
well
--
This message was sent by Atlassian Jira
(v8.3.4#803005)