Luke Chen created KAFKA-13230:
---------------------------------
Summary: port EmbeddedKafkaCluster back to auto clean up way
Key: KAFKA-13230
URL: https://issues.apache.org/jira/browse/KAFKA-13230
Project: Kafka
Issue Type: Improvement
Reporter: Luke Chen
Assignee: Luke Chen
discussion: [https://github.com/apache/kafka/pull/9858#discussion_r695328381]
2 problems caused after the migration in PR: #9858:
# resource leaks due to forgetting to clean up the EmbeddedKafkaCluster in an
integration test, or doing so in an incorrect way (eg such that a test failure
might skip the cleanup stage, a mistake that we've certainly encountered in our
tests in the past)
# breaking compatibility of integration tests across older branches, so that
if we ever need to backport a fix that includes an integration test -- which
many will/should do -- we can easily break the build of older branches by
accident. See for example [#11257|https://github.com/apache/kafka/pull/11257]:
aka the reason I started digging into this 🙂 . Even if we remember to fix this
during the backport, it's just an extra hassle.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
