Thanks Ryan, Read the KIP and it makes sense. +1 as well.
On Tue, Sep 7, 2021 at 1:42 PM Colin McCabe <cmcc...@apache.org> wrote: > +1 (binding) > > thanks, Ryan > > best, > Colin > > On Tue, Sep 7, 2021, at 09:47, Colin McCabe wrote: > > Hi Ryan, > > > > Thanks for working on this. I think it is almost ready to go. However, > > I left a comment about the wording of the KIP in the DISCUSS thread. > > > > best, > > Colin > > > > > > On Thu, Sep 2, 2021, at 13:20, Ryan Dielhenn wrote: > > > Hello kafka devs, > > > > > > I would like to start a vote on KIP-771. This KIP proposes to not > expose > > > controller metrics on KRaft brokers since KRaft brokers are not > controller > > > eligible and will never have a non-zero value for the metric. Since > > > exposing metrics that will always be zero is both unneeded and causes > > > non-negligible performance impact it would be best to not move forward > with > > > KAFKA-13140: https://github.com/apache/kafka/pull/11133 and instead > accept > > > this KIP. > > > > > > > > > > > > Here is a link to the KIP which documents the behavior change from how > > > controller metrics are exposed in a Kafka cluster using Zookeeper to > how > > > they are exposed in a Kafka cluster using KRaft. > > > : > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP+771%3A+KRaft+brokers+should+not+expose+controller+metrics > > > > > > Here is a link to the discussion: > > > > https://lists.apache.org/thread.html/r74432034527fab13cc973ad5187ef5881a642500d77b0d275dd7f018%40%3Cdev.kafka.apache.org%3E > > > > > > Regards, > > > Ryan Dielhenn > > > > > > -- -- Guozhang
