Chris Egerton created KAFKA-13329:
-------------------------------------

             Summary: Connect does not perform preflight validation for 
per-connector key and value converters
                 Key: KAFKA-13329
                 URL: https://issues.apache.org/jira/browse/KAFKA-13329
             Project: Kafka
          Issue Type: Bug
          Components: KafkaConnect
            Reporter: Chris Egerton
            Assignee: Chris Egerton


Users may specify a key and/or value converter class for their connector 
directly in the configuration for that connector. If this occurs, no preflight 
validation is performed to ensure that the specified converter is valid.

Unfortunately, the [Converter 
interface|https://github.com/apache/kafka/blob/4eb386f6e060e12e1940c0d780987e3a7c438d74/connect/api/src/main/java/org/apache/kafka/connect/storage/Converter.java]
 does not require converters to expose a {{ConfigDef}} (unlike the 
[HeaderConverter 
interface|https://github.com/apache/kafka/blob/4eb386f6e060e12e1940c0d780987e3a7c438d74/connect/api/src/main/java/org/apache/kafka/connect/storage/HeaderConverter.java#L48-L52],
 which does have that requirement), so it's unlikely that the configuration 
properties of the converter itself can be validated.

However, we can and should still validate that the converter class exists, can 
be instantiated (i.e., has a public, no-args constructor and is a concrete, 
non-abstract class), and implements the {{Converter}} interface.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to