----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23208/#review47151 -----------------------------------------------------------
Ship it! Looks good to me, although the connection quotas will not yet work if we are still using sth. like a hardware load balancer or a VIP. - Guozhang Wang On July 1, 2014, 7:42 p.m., Jay Kreps wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23208/ > ----------------------------------------------------------- > > (Updated July 1, 2014, 7:42 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1512 > https://issues.apache.org/jira/browse/KAFKA-1512 > > > Repository: kafka > > > Description > ------- > > KAFKA-1512 Add per-ip connection limits. > > > Diffs > ----- > > core/src/main/scala/kafka/network/SocketServer.scala > 4976d9c3a66bc965f5870a0736e21c7b32650bab > core/src/main/scala/kafka/server/KafkaConfig.scala > ef75b67b67676ae5b8931902cbc8c0c2cc72c0d3 > core/src/main/scala/kafka/server/KafkaServer.scala > c22e51e0412843ec993721ad3230824c0aadd2ba > core/src/test/scala/unit/kafka/network/SocketServerTest.scala > 62fb02cf02d3876b9804d756c4bf8514554cc836 > > Diff: https://reviews.apache.org/r/23208/diff/ > > > Testing > ------- > > > Thanks, > > Jay Kreps > >
