+1 (binding). Thanks for the KIP!
On Mon, Dec 13, 2021 at 11:14 AM Mickael Maison <mickael.mai...@gmail.com> wrote: > > Bumping this thread another time. > > This is a very minor change to make DescribeLogDirsResponse consistent > with the other APIs. > Let me know if you have any feedback. > > Thanks, > Mickael > > On Mon, Nov 22, 2021 at 10:29 AM Tom Bentley <tbent...@redhat.com> wrote: > > > > Hi Mickael, > > > > It's pretty low value, but I think consistency is a useful trait, and it's > > easily achievable here. > > > > +1 (binding). > > > > Kind regards, > > > > Tom > > > > > > On Thu, Nov 18, 2021 at 2:56 PM Mickael Maison <mickael.mai...@gmail.com> > > wrote: > > > > > Bumping this thread. > > > > > > Let me know if you have any feedback. > > > > > > Thanks, > > > Mickael > > > > > > On Wed, Oct 27, 2021 at 3:25 PM Luke Chen <show...@gmail.com> wrote: > > > > > > > > Hi Mickael, > > > > Thanks for the KIP. > > > > It's good to keep it consistent with others, to have top-level error > > > field. > > > > > > > > + 1 (non-binding) > > > > > > > > Thank you. > > > > Luke > > > > > > > > On Wed, Oct 27, 2021 at 9:01 PM Mickael Maison <mickael.mai...@gmail.com > > > > > > > > wrote: > > > > > > > > > Hi all, > > > > > > > > > > I'd like to start the vote on this minor KIP. > > > > > > > > > > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-784%3A+Add+top-level+error+code+field+to+DescribeLogDirsResponse > > > > > > > > > > Please take a look, vote or let me know if you have any feedback. > > > > > > > > > > Thanks > > > > > > > > > > >
