[
https://issues.apache.org/jira/browse/KAFKA-1513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14050261#comment-14050261
]
Evgeny Vereshchagin commented on KAFKA-1513:
--------------------------------------------
Looks like server could be just val.
I changed var to val and run tests. It's ok.
But I'm not sure that this change don't break something.
I'm reading dependent code.
I'll update patch if can understand that change safety.
> Cleanup KafkaServerStartable code
> ---------------------------------
>
> Key: KAFKA-1513
> URL: https://issues.apache.org/jira/browse/KAFKA-1513
> Project: Kafka
> Issue Type: Improvement
> Components: core
> Reporter: Evgeny Vereshchagin
> Priority: Minor
> Attachments: cleanup-kafkaserverstartable-code-v1.patch
>
>
> [init
> method|https://github.com/apache/kafka/blob/0.8.1/core/src/main/scala/kafka/server/KafkaServerStartable.scala#L26]
> too hard to understand.
> Var initialization would be simpler for readers.
> Patch will be soon. It's my first time:)
--
This message was sent by Atlassian JIRA
(v6.2#6252)
