Hi Ziming, Thanks for the update! It looks good now.
Only 1 minor comment: The file name in example can change to `kafka_admin_client.properties`, which should be much clear. Otherwise LGTM! Thanks for the improvement! Thank you. Luke On Thu, Jan 20, 2022 at 10:03 AM deng ziming <dengziming1...@gmail.com> wrote: > Hi everyone, > > I would like to restart a discussion for KIP-815 since the old KIP number > conflict with another KIP: > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-815%3A+Replace+KafkaConsumer+with+AdminClient+in+GetOffsetShell > < > https://cwiki.apache.org/confluence/display/KAFKA/KIP-815:+Replace+KafkaConsumer+with+AdminClient+in+GetOffsetShell > > > > The direct intention of this is to support max timestamp in > GetOffsetShell, This seems like a simple change but there are some things > to consider since it will change the --command-config parameter > > Let me know what you think. > > > Thanks, > Ziming Deng
