Thanks for the feedback Bruno and John. 1. Proposed name by John sounds good to me! 2. I will use processor-node metrics with debug level since this doesn't seem like top level metrics and make more sense to not mix them in task. 3. Will update KIP as Bruno suggested.
Thanks, Hao On Tue, Apr 12, 2022 at 1:30 AM Bruno Cadonna <cado...@apache.org> wrote: > Hi Hao, > > Thanks for the addition! > > I second what John said about the naming. > > Could you please describe the metrics as has been previously done in > KIP-471, KIP-613, or KIP-761? > That would make the metrics more concise and clear. In addition, > TaskMetrics is an internal class that is an implementation detail and > hence not intended to be shown in a KIP. > > Best, > Bruno > > On 12.04.22 06:03, John Roesler wrote: > > Thanks, Hao! > > > > I have no concern about amending the KIP to add metrics. > > Thanks for thinking of it. > > > > Can you comment on the choice to add them as a task-level metric > > instead of a processor-level metric? This will cause the metrics for > > all windowed aggregations in a task that use final emission to be > > mixed together. It might be fine, but we should at least document > > that it was anticipated and the reasons for the choice. By the way, > > if we do add them as processor-node metrics but want them to > > be measured at info level, we should also state it, since processor- > > node metrics are usually debug. > > > > Also, I'm concerned that the name `emitted-records` will be > > ambiguous in the larger context of all Kafka Streams metrics. If I'm > > right in thinking that these metrics are only for measuring the > > behavior of emit-final windowed aggregations, then we should > > make sure that the metric name says as much. Maybe: > > > > emit-final-records-[rate|total] > > emit-final-latency-[avg|max] > > > > Thanks! > > -John > > > > On Mon, Apr 11, 2022, at 14:25, Hao Li wrote: > >> Hi all, > >> > >> I would like to introduce two metrics in this KIP as well to measure the > >> latency and number of records emitted for emit final. They are named: > >> > >> `emit-final-latency` > >> `emitted-records` > >> > >> I've updated the KIP with details in > >> > https://cwiki.apache.org/confluence/display/KAFKA/KIP-825%3A+introduce+a+new+API+to+control+when+aggregated+results+are+produced > >> > >> Can you take a look and see if you have any concerns for the metrics? > >> > >> Thanks, > >> Hao > >> > >> On Fri, Mar 25, 2022 at 8:27 AM Hao Li <h...@confluent.io> wrote: > >> > >>> Got it. Forgot that. Yeah, it’s still open and ppl can still vote. > Thanks > >>> for reminding! > >>> > >>> Hao Li > >>> > >>>> On Mar 25, 2022, at 8:22 AM, Guozhang Wang <wangg...@gmail.com> > wrote: > >>>> > >>>> Hello Hao, > >>>> > >>>> According to bylaws the voting has to last for at least 72 business > >>> hours. > >>>> So let's wait a bit longer to see if there are different opinions > before > >>>> calling it close. > >>>> > >>>>> On Thu, Mar 24, 2022 at 4:20 PM Hao Li <h...@confluent.io.invalid> > >>> wrote: > >>>>> > >>>>> The vote happened in the discussion thread since I started the vote > >>> there > >>>>> by mistake. But it passed there. To avoid having everyone vote > again. I > >>>>> copied the content from that thread here: > >>>>> > >>>>> ======================== end of discussion thread vote > >>>>> ============================== > >>>>> The vote passed with 5 binding votes from John, Guozhang, Bruno, > >>> Matthias > >>>>> and Bill. > >>>>> > >>>>> Thanks all for the feedback and vote. > >>>>> > >>>>> Hao > >>>>> > >>>>>> On Thu, Mar 24, 2022 at 2:20 PM Bill Bejeck <bbej...@gmail.com> > wrote: > >>>>>> > >>>>>> Thanks for KIP Hao! > >>>>>> > >>>>>> Glad to see we settled on option 1 > >>>>>> > >>>>>> +1(binding) > >>>>>> > >>>>>> On Thu, Mar 24, 2022 at 5:13 PM Matthias J. Sax <mj...@apache.org> > >>>>> wrote: > >>>>>> > >>>>>>> +1 (binding) > >>>>>>> > >>>>>>> > >>>>>>> On 3/24/22 1:52 PM, Hao Li wrote: > >>>>>>>> I hit reply on my phone in the mail app and changed the title and > >>>>> text > >>>>>>>> hoping it will start a new thread. Apparently it doesn't work... > >>>>>>>> > >>>>>>>> On Thu, Mar 24, 2022 at 12:36 PM Bruno Cadonna < > cado...@apache.org> > >>>>>>> wrote: > >>>>>>>> > >>>>>>>>> Hi Hao, > >>>>>>>>> > >>>>>>>>> Actually, this is the VOTE thread. Do you use GMail? Sometimes it > >>>>> is a > >>>>>>>>> bit weird how it shows e-mails in threads. > >>>>>>>>> > >>>>>>>>> Anyways, thank you for the KIP and your patience! > >>>>>>>>> > >>>>>>>>> +1 (binding) > >>>>>>>>> > >>>>>>>>> Best, > >>>>>>>>> Bruno > >>>>>>>>> > >>>>>>>>> On 24.03.22 17:36, Hao Li wrote: > >>>>>>>>>> Thanks John and Guozhang. Didn't realize I used this discussion > >>>>>> thread > >>>>>>>>> for > >>>>>>>>>> voting. Let me start a new thread for voting. Will fix the KIP. > >>>>>>>>>> > >>>>>>>>>> On Thu, Mar 24, 2022 at 9:28 AM Guozhang Wang < > wangg...@gmail.com> > >>>>>>>>> wrote: > >>>>>>>>>> > >>>>>>>>>>> +1 (binding). > >>>>>>>>>>> > >>>>>>>>>>> Thanks Hao! > >>>>>>>>>>> > >>>>>>>>>>> > >>>>>>>>>>> Guozhang > >>>>>>>>>>> > >>>>>>>>>>> On Thu, Mar 24, 2022 at 9:20 AM John Roesler < > vvcep...@apache.org > >>>>>> > >>>>>>>>> wrote: > >>>>>>>>>>> > >>>>>>>>>>>> Thanks, Hao! > >>>>>>>>>>>> > >>>>>>>>>>>> I'm +1 (binding) > >>>>>>>>>>>> > >>>>>>>>>>>> -John > >>>>> > >>>>> ======================== start of discussion thread vote > >>>>> ============================== > >>>>> > >>>>> > >>>>>> On Thu, Mar 24, 2022 at 2:12 PM John Roesler <vvcep...@apache.org> > >>> wrote: > >>>>>> > >>>>>> Thanks, Hao, > >>>>>> > >>>>>> I’m +1 (binding) > >>>>>> > >>>>>> -John > >>>>>> > >>>>>> On Thu, Mar 24, 2022, at 11:38, Hao Li wrote: > >>>>>>> Hi all, > >>>>>>> > >>>>>>> I'd like to start a vote on Kafka Streams KIP-825: > >>>>>>> > >>>>>> > >>>>> > >>> > https://www.google.com/url?q=https://cwiki.apache.org/confluence/display/KAFKA/KIP-825%253A%2Bintroduce%2Ba%2Bnew%2BAPI%2Bto%2Bcontrol%2Bwhen%2Baggregated%2Bresults%2Bare%2Bproduced&source=gmail-imap&ust=1648826551000000&usg=AOvVaw0lio1vSNKnSnpYMVKn0eHe > >>>>>>> > >>>>>>> Thanks, > >>>>>>> Hao > >>>>>> > >>>>> > >>>>> > >>>>> -- > >>>>> Thanks, > >>>>> Hao > >>>>> > >>>> > >>>> > >>>> -- > >>>> -- Guozhang > >>> > >> > >> > >> -- > >> Thanks, > >> Hao > -- Thanks, Hao
