> I personally think puting the `Topic` column at the 1st column is better, and `Partition` as 2nd one. i.e. Topic:topic Partition:0 NO_TIMESTAMP Offset:123 key value
Thank you very much on the input. Putting topic in the front sounds good, but care must be taken if we want to suggest swapping the partition and timestamp like you proposed. Moreover, I personally believe that timestamp should remain in the first column. How about the following order: NO_TIMESTAMP Topic:topic Partition:0 Offset:123 key value Would this be preferable? I would like to ask for a suggestion on the column order, but let us avoid changing old behavior, that is, not printing topic should result in columns the same as before this KIP. To summarize: it seems there's no objections to the feature introduced and the output format so far, except on the subject of column ordering. On Sun, Apr 24, 2022, 20:09 Luke Chen <show...@gmail.com> wrote: > > I was refering to the ordering of the 'columns' as > they are printed. Right now, topic is printed before key and message. If > there is no concern, it will remain as such. > > Thanks for clarification. > > So, for the column ordering: > NO_TIMESTAMP Partition:0 Offset:123 Topic:topic key value > > I personally think puting the `Topic` column at the 1st column is better, > and `Partition` as 2nd one. i.e. > Topic:topic Partition:0 NO_TIMESTAMP Offset:123 key value > Topic:topic Partition:1 NO_TIMESTAMP Offset:456 key2 value2 > Topic:topic2 Partition:0 NO_TIMESTAMP Offset:789 key3 value3 > > But if you want to keep the scope of the KIP as is, it's fine to me. > We can create another KIP for the column ordering anytime. > > Thank you. > Luke > > > On Sun, Apr 24, 2022 at 6:35 PM Evans Jahja <evansjahj...@gmail.com> > wrote: > > > > I can imagine the ordering of the random topics records will be > > complicated > > and unpredicatable. > > > > Allow me to clarify. I was refering to the ordering of the 'columns' as > > they are printed. Right now, topic is printed before key and message. If > > there is no concern, it will remain as such. > > > > As for the ordering of the message printed, there is no intention to > > console-consumer on this topic. > > > > On Sun, Apr 24, 2022, 16:12 Luke Chen <show...@gmail.com> wrote: > > > > > +1 for printing anything we got without ordering. > > > I can imagine the ordering of the random topics records will be > > complicated > > > and unpredicatable. > > > > > > Thanks. > > > Luke > > > > > > On Fri, Apr 22, 2022 at 10:22 PM Evans Jahja <evansjahj...@gmail.com> > > > wrote: > > > > > > > Hi, everyone, > > > > > > > > Thanks for the comment on writing the example on KIP. I'm glad this > KIP > > > is > > > > well received. > > > > There's this other message queue called `nsq` with the consumer > program > > > > `nsq_tail` and it has the ability to print the topic, which is useful > > > when > > > > consuming from wildcard (includes), which led me to create this KIP. > > > > > > > > I've updated examples in the KIP, and I've also added the unit test > for > > > > this. > > > > > > > > As stated in the KIP, this is the expected output when we specify the > > > > topic: > > > > > > > > Topic:topic value > > > > > > > > and this is the expected output when we specify all of the print > > > > properties: > > > > > > > > NO_TIMESTAMP Partition:0 Offset:123 Topic:topic key > > value > > > > > > > > I think we can discuss if there's any requirements on the ordering. > > > > Personally, I wouldn't care so much about the ordering, as long as > the > > > > topic is included, but let's discuss if there are any suggestions > > > > regarding this. > > > > > > > > Thank you, > > > > > > > > Evans > > > > > > > > > > > > On Wed, Apr 20, 2022 at 1:59 PM Luke Chen <show...@gmail.com> wrote: > > > > > > > > > Hi Evans, > > > > > > > > > > This is a good feature that we missed before. > > > > > +1 to add an example. > > > > > I saw your WIP PR already added it, please put them into the KIP. > > > > > > > > > > Thank you. > > > > > Luke > > > > > > > > > > On Sat, Apr 16, 2022 at 7:39 AM John Roesler <vvcep...@apache.org> > > > > wrote: > > > > > > > > > > > Hi Evans, > > > > > > > > > > > > Thanks for the KIP! > > > > > > > > > > > > I agree with Mickael; it would be good to see an example in the > > KIP. > > > > > > > > > > > > Otherwise, I'm in favor. > > > > > > > > > > > > Thanks, > > > > > > -John > > > > > > > > > > > > On Fri, Apr 15, 2022, at 04:33, Mickael Maison wrote: > > > > > > > Hi, > > > > > > > > > > > > > > I can't believe this was missing! Thanks for addressing this. > > > > > > > Can you add an example of the expected output with the topic in > > the > > > > > KIP? > > > > > > > > > > > > > > Thanks, > > > > > > > Mickael > > > > > > > > > > > > > > On Sat, Apr 9, 2022 at 12:11 PM Evans Jahja < > > > evansjahj...@gmail.com> > > > > > > wrote: > > > > > > >> > > > > > > >> Good evening. > > > > > > >> > > > > > > >> My name is Evans, I am proposing KIP-829. > > > > > > >> > > > > > > >> Brief: Using `kafka-console-consumer` with `--include` > argument > > > > > listens > > > > > > >> from multiple topics, but there is no way to know which topic > > the > > > > > > message > > > > > > >> came from. This proposal allows printing the topic name. > > > > > > >> > > > > > > >> Requesting for comments. > > > > > > >> > > > > > > >> Confluence > > > > > > >> < > > > > > > > > > > > > > > > > > > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-829%3A+%28console-consumer%29+add+print.topic+property > > > > > > > > > > > > > >> Github <https://github.com/apache/kafka/pull/12012> > > > > > > >> > > > > > > >> Best Regards, > > > > > > >> > > > > > > >> Evans Jahja > > > > > > > > > > > > > > > > > > > > >
