Thanks for Divij's answer. One thing I'd like to add is that it'd be better if you can help investigate and fix those flaky tests. :)
Thank you. Luke On Tue, May 17, 2022 at 4:14 AM Divij Vaidya <divijvaidy...@gmail.com> wrote: > Hi Lim > > We have quite a few tests which are flaky and fail stochastically from time > to time. > > I would recommend that you check the tests which are failing for your PR. > Search for JIRA for the test failures. If you spot a flaky test JIRA for > the failure associated with your PR and the stack trace mentioned in the > JIRA is same as yours, then add this information to your PR. This activity > will help the reviewers understand whether the test failure are due to your > changes or not. > > Alternatively, another approach (which I don’t recommend) is keep adding > commits to the PR to trigger the full test run and hope one of them is > successful. > > Please feel free to ask questions if you need help with finding the flaky > test. > > On Mon, May 16, 2022 at 6:35 PM Lim Qingwei <l.q.we...@gmail.com> wrote: > > > Hi, I am a newbie. > > > > I noticed Jenkins builds are failing, is this expected? > > My PR has some failures, but I don't think they are relevant, how should > I > > proceed? > > > > Can I still request for reviews? > > > > Kind regards > > > -- > Divij Vaidya >
