Thanks everyone for your feedback and help. KIP-835 was approved with 3 binding votes from Guozhang, Luke and David.
On Thu, May 19, 2022 at 10:21 AM Guozhang Wang <wangg...@gmail.com> wrote: > > That makes sense. Thanks! > > +1 (binding). > > On Thu, May 19, 2022 at 8:46 AM José Armando García Sancio > <jsan...@confluent.io.invalid> wrote: > > > Guozhang Wang wrote: > > > > > > Thanks José! For 1/2 above, just checking if we would record the > > > corresponding sensors only during broker bootstrap time, or whenever > > there > > > are new metadata records being committed by the controller quorum (since > > > there are always a short period of time, between when the records are > > > committed, to when the records get fetched by that broker)? > > > > It measures the time spent by the broker keeping up with the log or > > processing the log. In practicality, when the broker starts that would > > be the time spent loading the snapshot and processing the committed > > records in the log after the snapshot. After startup that would be the > > time spent reading the log to keep up with the local high-watermark. I > > changed the name of the metric to "pending-record-processing-time-us". > > I think the word "load" in the previous metric name was awkward and > > misleading. > > > > -- > > -José > > > > > -- > -- Guozhang -- -José