Hi Sophie, A very minor comment but you might want to remove this KIP template related information from the top of the KIP:
*This page is meant as a template for writing a KIP <https://cwiki.apache.org/confluence/display/KAFKA/Kafka+Improvement+Proposals>. To create a KIP choose Tools->Copy on this page and modify with your content and replace the heading with the next KIP number and a description of your issue. Replace anything in italics with your own description.* Thanks! Sagar. On Mon, May 30, 2022 at 1:04 PM Sophie Blee-Goldman <[email protected]> wrote: > > > > Why does the title of the KIP talk about task-level metrics, but the > > specified metrics are on processor-level? > > > Ah, my mistake -- it should indeed say "processor-level metrics". Thanks > for the catch Bruno, the title has been fixed. > > Since there don't seem to be any concerns I'll proceed with kicking off the > vote. Thanks all! > > On Mon, May 30, 2022 at 12:01 AM Bruno Cadonna <[email protected]> wrote: > > > Thanks for the KIP, Sophie! > > > > I am also in favor of this KIP! > > > > I have one minor question: > > > > Why does the title of the KIP talk about task-level metrics, but the > > specified metrics are on processor-level? > > > > For the rest, I am +1. > > > > Best, > > Bruno > > > > On 29.05.22 00:20, John Roesler wrote: > > > Thanks for the well motivated and documented KIP, Sophie! I’m in favor > > of this change. > > > > > > -John > > > > > > On Sat, May 28, 2022, at 06:42, Sophie Blee-Goldman wrote: > > >> Hey all, > > >> > > >> I'd like to propose a very small KIP to add two metrics that will help > > fill > > >> a gap in the derivable produced and consumed metrics. Please take a > look > > >> and reply here with any questions or concerns. > > >> > > >> KIP-846: Task-level Streams metrics for bytes/records Produced > > >> < > > > https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=211886093 > > > > > >> > > >> Given the small nature of this I'm going to call for a vote soon, but > > >> please don't hesitate to raise anything you feel should be discussed > in > > >> more detail first. > > >> > > >> Thanks! > > >> Sophie > > >
