Hi all, While reviewing my PR for KIP-834, Bruno noticed a case that we may not have discussed enough.*
During the discussion, we decided that standby tasks would be paused. In order to do this, there are changes to the StoreChangelogReader around where it does restorations. Bruno noticed that the restoration of active tasks is not paused in my PR. >From my point of view, I was hoping to let active tasks restore/consume/etc in order that the Kafka Streams instance could transition to RUNNING (assuming that it was started paused). I believe Bruno's position is that if we are pausing restoration for standby tasks, then restoration should be paused for active tasks as well. Since this point hasn't been discussed like this, the KIP is unclear about this detail. What do folks think? Thanks in advance, Jim * https://github.com/apache/kafka/pull/12161#discussion_r886732983 On Mon, May 16, 2022 at 11:07 AM Jim Hughes <[email protected]> wrote: > Hi all, > > > With 5 binding votes (John, Bruno, Sophie, Matthias, Bill) and 4 > non-binding votes (Guozhang, Luke, Leah, Walker), the vote for KIP-834 > passes! > > > Thanks all for the great discussion. > > I have a PR up here: https://github.com/apache/kafka/pull/12161 > > > Thanks in advance for feedback on the PR! > > > Cheers, > > > JIm > > On Fri, May 13, 2022 at 12:04 PM Walker Carlson > <[email protected]> wrote: > >> +1 from me (non-binding) >> >> Walker >> >> On Wed, May 11, 2022 at 12:36 PM Leah Thomas <[email protected] >> > >> wrote: >> >> > Thanks Jim, great discussion. +1 from me (non-binding) >> > >> > Cheers, >> > Leah >> > >> > On Wed, May 11, 2022 at 10:14 AM Bill Bejeck <[email protected]> wrote: >> > >> > > Thanks for the KIP! >> > > >> > > +1 (binding) >> > > >> > > -Bill >> > > >> > > On Wed, May 11, 2022 at 9:36 AM Luke Chen <[email protected]> wrote: >> > > >> > > > Hi Jim, >> > > > >> > > > I'm +1. (please add some note in KIP about the stream resetting tool >> > > can't >> > > > be used in paused state) >> > > > Thanks for the KIP! >> > > > >> > > > Luke >> > > > >> > > > On Wed, May 11, 2022 at 9:09 AM Guozhang Wang <[email protected]> >> > > wrote: >> > > > >> > > > > Thanks Jim. +1 from me. >> > > > > >> > > > > On Tue, May 10, 2022 at 4:51 PM Matthias J. Sax <[email protected] >> > >> > > > wrote: >> > > > > >> > > > > > I had one minor question on the discuss thread. It's mainly >> about >> > > > > > clarifying and document the user contract. I am fine either way. >> > > > > > >> > > > > > +1 (binding) >> > > > > > >> > > > > > >> > > > > > -Matthias >> > > > > > >> > > > > > On 5/10/22 12:32 PM, Sophie Blee-Goldman wrote: >> > > > > > > Thanks for the KIP! +1 (binding) >> > > > > > > >> > > > > > > On Tue, May 10, 2022, 12:24 PM Bruno Cadonna < >> [email protected] >> > > >> > > > > wrote: >> > > > > > > >> > > > > > >> Thanks Jim, >> > > > > > >> >> > > > > > >> +1 (binding) >> > > > > > >> >> > > > > > >> Best, >> > > > > > >> Bruno >> > > > > > >> >> > > > > > >> On 10.05.22 21:19, John Roesler wrote: >> > > > > > >>> Thanks Jim, >> > > > > > >>> >> > > > > > >>> I’m +1 (binding) >> > > > > > >>> >> > > > > > >>> -John >> > > > > > >>> >> > > > > > >>> On Tue, May 10, 2022, at 14:05, Jim Hughes wrote: >> > > > > > >>>> Hi all, >> > > > > > >>>> >> > > > > > >>>> I'm asking for a vote on KIP-834: >> > > > > > >>>> >> > > > > > >> >> > > > > > >> > > > > >> > > > >> > > >> > >> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=211882832 >> > > > > > >>>> >> > > > > > >>>> Thanks in advance! >> > > > > > >>>> >> > > > > > >>>> Jim >> > > > > > >> >> > > > > > > >> > > > > > >> > > > > >> > > > > >> > > > > -- >> > > > > -- Guozhang >> > > > > >> > > > >> > > >> > >> >
