Hi Florin, Thanks for the comment! You brought up a very good point.. Actually I was focussed too much on the multicast operation and didn't pay attention to the other places where StramPartitioner is being used. TBH, I wasn't even aware that the StreamPartitioner is being used for FK joins so thanks definitely for pointing that out!
Regarding how we handle that, I think since the FK join uses the partition number info for subscription/message passing semantics, I would basically like to propose that we can throw an Exception when a user tries to pass an object which is an instance of MulticastPartitioner. This would keep things simple IMO because adding multicast keys to FK would just make it all the more complicated. Other than that, the usages/implementations of StreamPartitioner are on tests which would be taken care of if needed. Let me know what you think. Thanks! Sagar. On Sat, Jun 25, 2022 at 5:11 PM Florin Akermann <florin.akerm...@gmail.com> wrote: > Hi Sagar, > > Thanks for the KIP. > > I am wondering about the following. What about other classes than the > org.apache.kafka.streams.processor.internals.RecordCollectorImpl. Would > they still call .partition(...) and just crash? Or is it a given that they > never receive a reference to a Partitioner of > type MultiCastStreamPartitioner? > > Florin > > > On Sat, 28 May 2022 at 05:44, Sagar <sagarmeansoc...@gmail.com> wrote: > > > Hi All, > > > > I’m thinking to move this KIP to vote section if there aren’t any > > objections. > > > > Plz let me know if I that’s ok. > > > > Thanks! > > Sagar. > > > > On Tue, 24 May 2022 at 10:32 PM, Sagar <sagarmeansoc...@gmail.com> > wrote: > > > > > Hi All, > > > > > > Bumping this discussion thread again to see if there are any > > > comments/concerns on this. > > > > > > Thanks! > > > Sagar. > > > > > > On Wed, May 18, 2022 at 11:44 PM Sagar <sagarmeansoc...@gmail.com> > > wrote: > > > > > >> Hi All, > > >> > > >> I would like to open a discussion thread on > > >> > > > https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=211883356 > > >> . > > >> > > >> Thanks! > > >> Sagar. > > >> > > > > > >
