Hi Guozhang, Thanks for the KIP. Some comments: 1. I have the same question as Ziming, should we also add an option in kafka-consumer-groups.sh in this KIP? Or you'd like to keep the current scope, and other people can create a follow-up KIP to address the kafka-consumer-groups.sh script? 2. The setter method name: `shouldRequireStable` might need to rename to `requireStable` to be consistent with above `topicPartitions` getter/setter
Thank you. Luke On Fri, Jul 1, 2022 at 11:17 AM John Roesler <vvcep...@apache.org> wrote: > Thanks for the KIP, Guozhang! > > I’m +1 (binding) > > -John > > On Thu, Jun 30, 2022, at 21:17, deng ziming wrote: > > Thanks for this KIP, > > we have a kafka-consumer-groups.sh shell which is based on the API you > > proposed to change, is it worth update it as well? > > > > -- > > Best, > > Ziming > > > >> On Jul 1, 2022, at 9:04 AM, Guozhang Wang <wangg...@gmail.com> wrote: > >> > >> Hello folks, > >> > >> I'd like to call out for a vote for the following KIP to expose the > >> requireStable flag inside admin client's options as well: > >> > >> > https://cwiki.apache.org/confluence/display/KAFKA/KIP-851%3A+Add+requireStable+flag+into+ListConsumerGroupOffsetsOptions > >> > >> Any feedback as well as your votes are welcome. > >> > >> -- Guozhang >
