Hi José, Would it be okay to backport https://github.com/apache/kafka/pull/12451 to the current 3.3 branch? It's a strictly cosmetic change that updates a misleading comment about exactly-once support for source connectors. I'm hoping it'll make life easier for anyone who has to debug this feature by saving some confusion.
Cheers, Chris On Thu, Jul 21, 2022 at 11:11 PM Luke Chen <show...@gmail.com> wrote: > Hi Jose, > > I just found the KIP-831 is not listed in the v3.3 planned KIPs. > It is completed and merged. > Please help add it. > > Thank you. > Luke > > On Fri, Jul 22, 2022 at 4:56 AM Randall Hauch <rha...@gmail.com> wrote: > > > Hi, Jose. > > > > Thanks for driving the 3.3.0 release. > > > > Chris E and Chris S both mentioned > > https://issues.apache.org/jira/browse/KAFKA-14079 in this thread a few > > days > > ago. This was deemed a critical bug fix for 3.2, and the PR for the `3.2` > > branch [1] has already been merged and is in the recently-cut 3.2.1 RC. > > Likewise, the PR for the `trunk` branch [2] has also been merged. Will > you > > approve me merging the fix to the `3.3` branch for inclusion in 3.3.0? > > > > Best regards, > > > > Randall > > > > [1] https://github.com/apache/kafka/pull/12412 > > [2] https://github.com/apache/kafka/pull/12415 > > > > On Sun, Jul 17, 2022 at 5:46 PM Christopher Shannon < > > christopher.l.shan...@gmail.com> wrote: > > > > > I submitted a tweaked PR for 3.3.0 based on the 3.2.1 fix here: > > > https://github.com/apache/kafka/pull/12415 > > > > > > On Sun, Jul 17, 2022 at 1:52 PM Chris Egerton <fearthecel...@gmail.com > > > > > wrote: > > > > > > > Hi all, > > > > > > > > Although KAFKA-14079 is not a regression, it'd be nice if we could > get > > it > > > > into 3.3.0. As I mentioned on the 3.2.1 release thread, the risk is > > > fairly > > > > low (the functional changes are just two lines long), and the impact > is > > > > high for users who have configured source connectors with > > > > "errors.tolerance" set to "all". > > > > > > > > Given that the code freeze for the release is coming up soon (the > > release > > > > doc currently has it at July 20th), it'd be nice if we could get some > > > eyes > > > > on the PR for 3.2.1 and, if that looks good, a PR for trunk and > 3.3.0. > > > > > > > > Cheers, > > > > > > > > Chris > > > > > > > > On Sat, Jul 16, 2022 at 12:31 PM Christopher Shannon < > > > > christopher.l.shan...@gmail.com> wrote: > > > > > > > > > There is a bug I found that I think is worthwhile fixing in 3.3.0 > (I > > > also > > > > > sent a note to 3.2.1 thread): > > > > > https://issues.apache.org/jira/browse/KAFKA-14079 > > > > > > > > > > On Thu, Jul 14, 2022 at 7:56 PM Jason Gustafson > > > > <ja...@confluent.io.invalid > > > > > > > > > > > wrote: > > > > > > > > > > > Hey Jose, > > > > > > > > > > > > Thanks for volunteering to manage the release! KIP-833 is > currently > > > > > slotted > > > > > > for 3.3. We've been getting some help from Jack Vanlighty to > > validate > > > > the > > > > > > raft implementation in TLA+ and with frameworks like Jepsen. The > > > > > > specification is written here if anyone is interested: > > > > > > > > > > > > > > > > > > > > > > > > > > > https://github.com/Vanlightly/raft-tlaplus/blob/main/specifications/pull-raft/KRaft.tla > > > > > > . > > > > > > The main gap that this work uncovered in our implementation is > > > > documented > > > > > > here: https://issues.apache.org/jira/browse/KAFKA-14077. I do > > > believe > > > > > that > > > > > > KIP-833 depends on fixing this issue, so I wanted to see how you > > feel > > > > > about > > > > > > giving us a little more time to address it? > > > > > > > > > > > > Thanks, > > > > > > Jason > > > > > > > > > > > > On Wed, Jul 13, 2022 at 10:01 AM Sagar < > sagarmeansoc...@gmail.com> > > > > > wrote: > > > > > > > > > > > > > Hey Jose, > > > > > > > > > > > > > > Well actually I have 2 approved PRs from Kafka Connect: > > > > > > > > > > > > > > https://github.com/apache/kafka/pull/12321 > > > > > > > https://github.com/apache/kafka/pull/12309 > > > > > > > > > > > > > > Not sure how to get these merged though but I think these can > go > > > into > > > > > 3.3 > > > > > > > release. > > > > > > > > > > > > > > Thanks! > > > > > > > Sagar. > > > > > > > > > > > > > > > > > > > > > On Wed, Jul 13, 2022 at 5:03 PM Divij Vaidya < > > > > divijvaidy...@gmail.com> > > > > > > > wrote: > > > > > > > > > > > > > > > Hey Jose > > > > > > > > > > > > > > > > A few of my PRs are pending review for quite some which I was > > > > hoping > > > > > to > > > > > > > > merge into 3.3. I have already marked them with "Fix > > > version=3.3.0" > > > > > so > > > > > > > that > > > > > > > > you can track them using the JIRA filter you shared earlier > > > > > > > > < > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > https://issues.apache.org/jira/issues/?jql=project%20%3D%20KAFKA%20AND%20fixVersion%20%3D%203.3.0%20AND%20status%20not%20in%20(resolved%2C%20closed)%20ORDER%20BY%20priority%20DESC%2C%20status%20DESC%2C%20updated%20DESC%20%20%20%20%20%20 > > > > > > > > > > > > > > > > > in this thread. Would you have some time to review them? > > > > > > > > > > > > > > > > Notable amongst them would be: > > > > > > > > 1. Fix the rate window size calculation for edge cases - > > > > > > > > https://github.com/apache/kafka/pull/12184 > > > > > > > > 2. Fix resource leaks - > > > https://github.com/apache/kafka/pull/12228 > > > > > > > > > > > > > > > > And the complete list would be at: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > https://github.com/search?q=is%3Aopen+is%3Apr+author%3Adivijvaidya+is%3Apr+repo%3Aapache%2Fkafka+created%3A2022-04-01..2022-07-30&type=Issues > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > > > Divij Vaidya > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > On Mon, Jul 11, 2022 at 5:12 PM José Armando García Sancio > > > > > > > > <jsan...@confluent.io.invalid> wrote: > > > > > > > > > > > > > > > > > Hi all, > > > > > > > > > > > > > > > > > > I created the branch for 3.3 > > > > > > > > > (https://github.com/apache/kafka/tree/3.3). If you have > bug > > > > fixes > > > > > > for > > > > > > > > > the 3.3.0 release please make sure to cherry pick them to > > that > > > > > > branch. > > > > > > > > > > > > > > > > > > Thanks > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > >
