Hi José, Thanks for having a look at this KIP and thanks for pointing this out, I've had a look at KIP-856.
It's good to see there's some overlap in our proposals. we're both proposing: - Identifying log directories with a UUID - Extending the storage tool to ensure each log directory has a UUID assigned - Expanding the topic partition identity to include the log directory UUID There were differences in our proposals as to how the UUID is to be persisted, but I've changed my proposal to match yours — I think adding storage.id to meta.properties makes sense. -- Igor On Wed, Jul 27, 2022, at 4:42 PM, José Armando García Sancio wrote: > Hi Igor, > > Thanks for the KIP. Looking forward to this improvement. I'll review your KIP. > > I should mention that I started a discussion thread on KIP-856: KRaft > Disk Failure Recovery at > https://lists.apache.org/thread/ytv0t18cplwwwqcp77h6vry7on378jzj > > Both keep introducing similar concepts. For example both KIP introduce > a storage uuid that is stored in meta.properties. At first glance > there are some minor differences. I suggest that we review each > other's KIP so that we can remove these minor differences. What do you > think? > > Thanks! > -- > -José
