-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23655/
-----------------------------------------------------------
(Updated July 17, 2014, 7:50 p.m.)
Review request for kafka.
Bugs: KAFKA-687
https://issues.apache.org/jira/browse/KAFKA-687
Repository: kafka
Description (updated)
-------
The comments in the code and the summary are pretty self-explanatory.
Things to think about:
* Naming - do symmetric/range/roundrobin make sense?
* The comments briefly summarize why we needed a separate symmetric mode but
let me know if that is unclear.
* Rebalance time will be slightly higher - I have not measured (will do that)
* I would like to add some mbeans to show ownership counts.
Diffs
-----
core/src/main/scala/kafka/consumer/ConsumerConfig.scala
1cf2f62ba02e4aa66bfa7575865e5d57baf82212
core/src/main/scala/kafka/consumer/PartitionAllocator.scala PRE-CREATION
core/src/main/scala/kafka/consumer/TopicCount.scala
c79311097c5bd6718cb6a7fc403f804a1a939353
core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala
65f518d47c7555c42c4bff39c211814831f4b8b6
core/src/main/scala/kafka/utils/ZkUtils.scala
dcdc1ce2b02c996294e19cf480736106aaf29511
core/src/test/scala/unit/kafka/consumer/PartitionAllocatorTest.scala
PRE-CREATION
Diff: https://reviews.apache.org/r/23655/diff/
Testing (updated)
-------
* I did the unit tests (including the new one) as well as mirror maker system
test suite with roundrobin. While this is being reviewed I will run the system
tests with symmetric
Thanks,
Joel Koshy
