On 2023/02/15 14:29:06 Ismael Juma wrote:
> Hi.
>
> Is MessageReader the right name? The client apis tend to use the word
> `Record` instead. In fact, `readMessage` returns a `ProducerRecord`.
Make sense. “Record” is the better naming. I will update KIP to use “Record”
instead of “message”
>
> Also, I wonder if we it would be useful for the interface to support the
> usage of Serializers. That is, the interface could return ProducerRecord<T>
> as long as a serializer was also configured. I am less sure about this one,
> but worth giving it some thought and if we think it's a bad idea, we should
> add it to the "Rejected Alternatives" section.
It seems to me the serializer should be a part of implementation of
MessageReader. If the custom serializer is supported, users have to define two
class (reader and serializer) to convert bytes (from input stream) to “correct
records”.
I will add it to dejected alternatives
>
> Ismael
>
> On Wed, Feb 15, 2023 at 3:07 AM Mickael Maison <mickael.mai...@gmail.com>
> wrote:
>
> > Hi Chia-Ping,
> >
> > Sorry nobody replied to your thread earlier!
> > I stumbled on this while looking at
> > https://issues.apache.org/jira/browse/KAFKA-14525 (migrating CLI tools
> > out of core). Your proposal still makes sense and would help migrating
> > the ConsoleProducer tool.
> >
> > Can we specify when we expect to delete kafka.common.MessageReader? I
> > guess in Kafka 4.0?
> > Apart from that, the KIP looks good and considering how simple it is,
> > you should be able to open a vote thread.
> >
> > Thanks,
> > Mickael
> >
> > On Tue, Jul 7, 2020 at 5:55 PM Chia-Ping Tsai <chia7...@apache.org> wrote:
> > >
> > > hi all,
> > >
> > > I would like to start the discussion for KIP-641.
> > >
> > >
> > https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=158866569
> > >
> > > Many thanks,
> > >
> > > Chia-Ping
> >
>
