> On July 19, 2014, 11:28 p.m., Timothy Chen wrote: > > core/src/main/scala/kafka/server/KafkaConfig.scala, line 64 > > <https://reviews.apache.org/r/23702/diff/2/?file=636339#file636339line64> > > > > Why reduce the range to 1000? > > > > Sriharsha Chintalapani wrote: > As we go with auto-generating broker id we want to have a backward > compatibility where a user can continue to provide brokerId as part of > server.properties we will give preference to the user provided brokerId if it > presents instead a of generating a new seqId from zookeeper. > 1000 here is more of a reserved number for user provided config and to > avoid conflict with zookeeper generated seqId. For more details > please check comments by Jay Kreps here > https://issues.apache.org/jira/browse/KAFKA-1070. Thanks.
I see, a comment and a constant will be helpful for what it is. - Timothy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23702/#review48184 ----------------------------------------------------------- On July 19, 2014, 11:06 p.m., Sriharsha Chintalapani wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23702/ > ----------------------------------------------------------- > > (Updated July 19, 2014, 11:06 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1070 > https://issues.apache.org/jira/browse/KAFKA-1070 > > > Repository: kafka > > > Description > ------- > > KAFKA-1070. Auto assign node id. > > > Diffs > ----- > > core/src/main/scala/kafka/common/InconsistentBrokerIdException.scala > PRE-CREATION > core/src/main/scala/kafka/server/KafkaConfig.scala > 50b09edb73af1b45f88f919ac8c46ae056878c8e > core/src/main/scala/kafka/server/KafkaServer.scala > def1dc2a5818d45d9ee0881137ff989cec4eb9b1 > core/src/main/scala/kafka/utils/ZkUtils.scala > dcdc1ce2b02c996294e19cf480736106aaf29511 > core/src/test/scala/unit/kafka/server/ServerGenerateBrokerIdTest.scala > PRE-CREATION > core/src/test/scala/unit/kafka/utils/TestUtils.scala > 3faa884f8eb83c7c00baab416d0acfb488dc39c1 > > Diff: https://reviews.apache.org/r/23702/diff/ > > > Testing > ------- > > > Thanks, > > Sriharsha Chintalapani > >
