Hi Steven, Thanks for your contribution! This is definitively a process we need to automate. I left a few comments in your PRs.
Thanks, Mickael On Tue, Jun 13, 2023 at 8:11 PM Lovish Madhu <lovish.madhu.2...@gmail.com> wrote: > > Looks good, but I am also a newbie. > > However I feel like variables such as n = 10 as some meaningful variable > name as it is global constant. > Also you forgot to use n and instead used 10 > here: refreshed_collaborators[:10] > > On Tue, Jun 13, 2023 at 11:23 PM Steven Booke <steviebee...@gmail.com> > wrote: > > > To whom this may concern, > > > > This is my first time contributing and I have just submitted my first PR. I > > have made changes to both apache/kafka-site and apache/kafka repos. I > > believe I have followed the detailed instructions for contributing a code > > change and am looking for feedback. > > > > Here are the PRs for reference: https://github.com/apache/kafka/pull/13842 > > and https://github.com/apache/kafka-site/pull/521 > > > > Here is the JIRA ticket for reference: > > https://issues.apache.org/jira/browse/KAFKA-14995 > > > > -- > > Regards > > > > Steven Booke > >
