Jose, Using the term "node" makes sense since it follows convention, and then "NodeEndpoints" can be reused in future. Update the KIP with protocol message changes.
On Fri, Jul 14, 2023 at 5:53 PM José Armando García Sancio <jsan...@confluent.io.invalid> wrote: > Hi Mayank, > > On Thu, Jul 13, 2023 at 10:03 AM Mayank Shekhar Narula > <mayanks.nar...@gmail.com> wrote: > > 3. If I understood this correctly, certain replicas "aren't" brokers, > what > > are they then? > > In a Kafka KRaft cluster they can be either brokers, controllers or > both. The term we use is node. A Kafka node can be either a broker, > controller or both. For example, we have the following configuration > documentation: > > node.id > The node ID associated with the roles this process is playing when > `process.roles` is non-empty. This is required configuration when > running in KRaft mode. > > From https://kafka.apache.org/documentation/#brokerconfigs_node.id > > > Also how about replacing "Replica" with "Leader", this is more readable > on > > the client. so, how about this? > > I vote for "Node". Note that this array is a mapping of replica/node > id to their endpoint. For example, in the future we may use it to send > endpoint information when sending the replica id to fetch from a > follower. > > Thanks, > -- > -José > -- Regards, Mayank Shekhar Narula
