[ 
https://issues.apache.org/jira/browse/KAFKA-1419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14073651#comment-14073651
 ] 

Joe Crobak commented on KAFKA-1419:
-----------------------------------

I tried out this patch earlier today, and I have a few pieces of feedback:

* I'm not sure it's possible to support both scala 2.8 and 2.11 at the same 
time while using the zinc compiler. 2.8 seems to require gradle 1.6/zinc 0.2.5, 
and 2.11 requires gradle 2.0/zinc 0.3.0+. It's possible that there's a version 
in between that supports them, but I didn't do the binary search. Switching to 
{{scalaCompileOptions.useAnt = true}} seems to compile all scala versions for 
me.
* I think the {{jarAll}}, {{srcJarAll}} and other `*All` tasks should be 
updated to include scala 2.11.
* scala 2.9 support seems to be broken by two things: 1) several {{else{}}} 
clauses were formerly scala 2.9 specific but were converted to be scala 2.11 
specific. 2) wrong zinc version being selected.
* Moving {{BeanProperty}} from {{scala.reflect}} to {{scala.beans}} is 
backwards incompatible with scala <2.10. it's likely better to remove the 
{{BeanProperty}} dep and implement {{def getBuffer = buffer}} in those two 
places.
* scala.gradle needs an override for 2.11 like it has for 2.10.

I have a feeling that trying to support 4 versions of scala is going to be a 
pain in the long run—when can scala 2.8 (and also 2.9) be dropped?

> cross build for scala 2.11
> --------------------------
>
>                 Key: KAFKA-1419
>                 URL: https://issues.apache.org/jira/browse/KAFKA-1419
>             Project: Kafka
>          Issue Type: Improvement
>          Components: clients
>    Affects Versions: 0.8.1
>            Reporter: Scott Clasen
>            Assignee: Ivan Lyutov
>            Priority: Blocker
>             Fix For: 0.8.2
>
>         Attachments: KAFKA-1419.patch, KAFKA-1419.patch
>
>
> Please publish builds for scala 2.11, hopefully just needs a small tweak to 
> the gradle conf?



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to