[
https://issues.apache.org/jira/browse/KAFKA-1549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14075475#comment-14075475
]
nicu marasoiu edited comment on KAFKA-1549 at 7/26/14 7:46 PM:
---------------------------------------------------------------
Agreed, makes sense - attached patch.
I wonder why I did not receive an email on gmail with your comment, since I am
subscribed (watching) this issue, do you have any idea why?
was (Author: nmarasoi):
attached
> dead brokers coming in the TopicMetadataResponse
> ------------------------------------------------
>
> Key: KAFKA-1549
> URL: https://issues.apache.org/jira/browse/KAFKA-1549
> Project: Kafka
> Issue Type: Bug
> Affects Versions: 0.8.2
> Environment: trunk
> Reporter: nicu marasoiu
> Assignee: nicu marasoiu
> Attachments: bringAllBrokers.patch
>
>
> JunRao confirming my observation that brokers are only added to the
> metadataCache, never removed: "The way that we update liveBrokers in
> MetadataCache.updateCache() doesn't seem right. We only add newly received
> live brokers to the list. However, there could be existing brokers in that
> list that are now dead. Those dead brokers shouldn't be returned to the
> clients. We should probably just take the new live broker list and cache it."
--
This message was sent by Atlassian JIRA
(v6.2#6252)
