Hi Hanyu,
Thanks for the KIP!
1)
Could you please mark the pieces that you want to add to the API in the
code listing in the KIP? You can add a comment like "// newly added" or
similar. That would make reading the KIP a bit easier because one does
not need to compare your code with the code in the current codebase.
2)
Could you -- as a side cleanup -- also change the getters to not use the
get-prefix anymore, please? That was apparently an oversight when those
methods were added. Although the API is marked as Evolving, I think we
should still deprecate the getX() methods, since it does not cost us
anything.
3)
I propose to make the API a bit more fluent. For example, something like
WindowRangeQuery.withKey(key).fromTime(t1).toTime(t2)
and
WindowRangeQuery.withAllKeys().fromTime(t1).toTime(t2)
and
WindowRangeQuery.withKeyRange(key1, key2).fromTime(t1).toTime(t2)
and maybe even in addition to the above add also the option to start
with the time range
WindowRangeQuery.withWindowStartRange(t1, t2).fromKey(key1).toKey(key2)
4)
Could you also add some usage examples? Alieh did quite a nice job
regarding usage examples in KIP-986.
Best,
Bruno
On 11/8/23 8:02 PM, Hanyu (Peter) Zheng wrote:
Hello everyone,
I would like to start the discussion for KIP-997: Support fetch(fromKey,
toKey, from, to) to WindowRangeQuery and unify WindowKeyQuery and
WindowRangeQuery
The KIP can be found here:
https://cwiki.apache.org/confluence/display/KAFKA/KIP-997%3A++Support+fetch%28fromKey%2C+toKey%2C+from%2C+to%29+to+WindowRangeQuery+and+unify+WindowKeyQuery+and+WindowRangeQuery
Any suggestions are more than welcome.
Many thanks,
Hanyu
On Wed, Nov 8, 2023 at 10:38 AM Hanyu (Peter) Zheng <pzh...@confluent.io>
wrote:
https://cwiki.apache.org/confluence/display/KAFKA/KIP-997%3A++Support+fetch%28fromKey%2C+toKey%2C+from%2C+to%29+to+WindowRangeQuery+and+unify+WindowKeyQuery+and+WindowRangeQuery
--
[image: Confluent] <https://www.confluent.io>
Hanyu (Peter) Zheng he/him/his
Software Engineer Intern
+1 (213) 431-7193 <+1+(213)+431-7193>
Follow us: [image: Blog]
<https://www.confluent.io/blog?utm_source=footer&utm_medium=email&utm_campaign=ch.email-signature_type.community_content.blog>[image:
Twitter] <https://twitter.com/ConfluentInc>[image: LinkedIn]
<https://www.linkedin.com/in/hanyu-peter-zheng/>[image: Slack]
<https://slackpass.io/confluentcommunity>[image: YouTube]
<https://youtube.com/confluent>
[image: Try Confluent Cloud for Free]
<https://www.confluent.io/get-started?utm_campaign=tm.fm-apac_cd.inbound&utm_source=gmail&utm_medium=organic>
