Philip Nee created KAFKA-15866:
----------------------------------

             Summary: Refactor OffsetFetchRequestState Error handling to be 
more consistent with OffsetCommitRequestState
                 Key: KAFKA-15866
                 URL: https://issues.apache.org/jira/browse/KAFKA-15866
             Project: Kafka
          Issue Type: Improvement
            Reporter: Philip Nee


The current OffsetFetchRequestState error handling uses nested if-else, which 
is quite different, stylistically, to the OffsetCommitRequestState using a 
switch statment.  The latter is a bit more readable so we should refactor the 
error handling using the same style to improve readability.

 

A minor point: Some of the error handling seems inconsistent with the commit. 
The logic was from the current implementation, so we should also review all the 
error handling.  For example: somehow the current logic doesn't mark the 
coordinator unavailable when receiving COORDINATOR_NOT_AVAILABLE



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to