Thanks for the KIP, Kamal. The change looks good to me, though, I think we can do a better job at documenting what the error means for the clients and users.
Correct me if I'm wrong, when remote metadata is being synced on a new leader, we cannot fetch even the local data (as per [1]), hence, partition is considered "unreadable" but writes (and all other operations such as admin operations) can continue to work on that partition. If my understanding is correct, perhaps, please clarify this in the error description. In absence of it, it is difficult to determine what this error means for operations that can be performed on a partition. [1] https://github.com/apache/kafka/blob/82808873cbf6a95611243c2e7984c4aa6ff2cfff/core/src/main/scala/kafka/log/UnifiedLog.scala#L1336 -- Divij Vaidya On Tue, Dec 12, 2023 at 9:58 AM Kamal Chandraprakash < kamal.chandraprak...@gmail.com> wrote: > Thanks Luke for reviewing this KIP! > > If there are no more comments from others, I'll start the VOTE since this > is a minor KIP. > > On Mon, Dec 11, 2023 at 1:01 PM Luke Chen <show...@gmail.com> wrote: > > > Hi Kamal, > > > > Thanks for the KIP! > > LGTM. > > > > Thanks. > > Luke > > > > On Wed, Nov 22, 2023 at 7:28 PM Kamal Chandraprakash < > > kamal.chandraprak...@gmail.com> wrote: > > > > > Hi, > > > > > > I would like to start a discussion to introduce a new error code for > > > retriable remote storage errors. Please take a look at the proposal: > > > > > > > > > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-1007%3A+Introduce+Remote+Storage+Not+Ready+Exception > > > > > >
