> On Aug. 5, 2014, 2:24 p.m., Joe Stein wrote: > > gradle.properties, line 18 > > <https://reviews.apache.org/r/23895/diff/5/?file=652031#file652031line18> > > > > I think this should be 2.9.2 but confirming with Jun that is what we > > are going to be recommending when 0.8.2 releases.
Joe, I agree with you that 2.11.2 seems relatively new. So perhaps we shouldn't default to it now. On the other hand, 2.9.2 is pretty old. How about we default to 2.10.1? We also need to change kafka-run-class.sh accordingly. - Jun ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23895/#review49600 ----------------------------------------------------------- On Aug. 5, 2014, 12:52 p.m., Ivan Lyutov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23895/ > ----------------------------------------------------------- > > (Updated Aug. 5, 2014, 12:52 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1419 > https://issues.apache.org/jira/browse/KAFKA-1419 > > > Repository: kafka > > > Description > ------- > > KAFKA-1419 - cross build for scala 2.11 - dropped scala 2.8 support - minor > bug fixes > > > KAFKA-1419 - cross build for scala 2.11 - changed 2.11 specific dependency > version - updated scala version to 2.11.2 - added getBuffer to > ByteBufferMessageSet classes > > > KAFKA-1419 - cross build for scala 2.11 - changed 2.11 specific dependency > version - updated scala version to 2.11.2 - added getBuffer to > ByteBufferMessageSet classes - removed annotations 2.8 file > > > KAFKA-1419 - cross build for scala 2.11 - changed 2.11 specific dependency > version - updated scala version to 2.11.2 - added getBuffer to > ByteBufferMessageSet classes - removed annotations 2.8 file - updated > kafka-run-class.sh to run kafka classes with proper version > > > Diffs > ----- > > bin/kafka-run-class.sh 5d5021dff8daeaf8e35923f6df31d7fc3d850e68 > build.gradle a72905df824ba68bed5d5170d18873c23e1782c9 > core/src/main/scala/kafka/javaapi/message/ByteBufferMessageSet.scala > fecee8d5f7b32f483bb1bfc6a5080d589906f9c4 > core/src/main/scala/kafka/message/ByteBufferMessageSet.scala > 73401c5ff34d08abce22267aa9c4d86632c6fb74 > core/src/main/scala/kafka/utils/Annotations_2.8.scala > 28269eb037109f7680b9da732e4baa51c9a594b6 > core/src/main/scala/kafka/utils/Annotations_2.9+.scala > gradle.properties 4827769a3f8e34f0fe7e783eb58e44d4db04859b > gradle/buildscript.gradle 225e0a82708bc5f390e5e2c1d4d9a0d06f491b95 > gradle/wrapper/gradle-wrapper.properties > 610282a699afc89a82203ef0e4e71ecc53761039 > scala.gradle ebd21b870c0746aade63248344ab65d9b5baf820 > > Diff: https://reviews.apache.org/r/23895/diff/ > > > Testing > ------- > > > Thanks, > > Ivan Lyutov > >
