Re: Review Request 24340: Patch for KAFKA-1565

[Dong Lin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24340/
-----------------------------------------------------------

(Updated Aug. 5, 2014, 9:51 p.m.)


Review request for kafka.


Bugs: KAFKA-1565
    https://issues.apache.org/jira/browse/KAFKA-1565


Repository: kafka


Description (updated)
-------

KAFKA-1522 Tansactional messaging request/response definitions


KAFKA-1565 Transaction manager failover handling


Diffs (updated)
-----

  core/src/main/scala/kafka/admin/TopicCommand.scala 
8d5c2e7088fc6e8bf69e775ea7f5893b94580fdf 
  core/src/main/scala/kafka/api/RequestKeys.scala 
fbfc9d3aeaffed4ca85902125fcc1050086835db 
  core/src/main/scala/kafka/api/TransactionRequest.scala PRE-CREATION 
  core/src/main/scala/kafka/api/TransactionResponse.scala PRE-CREATION 
  core/src/main/scala/kafka/api/TxCoordinatorMetadataRequest.scala PRE-CREATION 
  core/src/main/scala/kafka/api/TxCoordinatorMetadataResponse.scala 
PRE-CREATION 
  core/src/main/scala/kafka/cluster/Partition.scala 
f2ca8562f833f09d96ec4bd37efcacf69cd84b2e 
  core/src/main/scala/kafka/common/ErrorMapping.scala 
5559d26ba2b96059f719754a351fa4598ca8a70b 
  core/src/main/scala/kafka/common/Topic.scala 
ad759786d1c22f67c47808c0b8f227eb2b1a9aa8 
  core/src/main/scala/kafka/controller/ControllerChannelManager.scala 
8763968fbff697e4c5c98ab1274627c192a4d26a 
  core/src/main/scala/kafka/message/Message.scala 
d2a7293c7be4022af30884330924791340acc5c1 
  core/src/main/scala/kafka/server/KafkaApis.scala 
0b668f230c8556fdf08654ce522a11847d0bf39b 
  core/src/main/scala/kafka/server/KafkaConfig.scala 
ef75b67b67676ae5b8931902cbc8c0c2cc72c0d3 
  core/src/main/scala/kafka/server/KafkaServer.scala 
c22e51e0412843ec993721ad3230824c0aadd2ba 
  core/src/main/scala/kafka/server/ReplicaManager.scala 
6a56a772c134dbf1e70c1bfe067223009bfdbac8 
  core/src/main/scala/kafka/server/RequestPurgatory.scala 
3d0ff1e2dbd6a5c3587cffa283db70415af83a7b 
  core/src/main/scala/kafka/server/TransactionManager.scala PRE-CREATION 
  core/src/main/scala/kafka/utils/ZkUtils.scala 
dcdc1ce2b02c996294e19cf480736106aaf29511 
  core/src/test/scala/unit/kafka/api/RequestResponseSerializationTest.scala 
a2117b34c2ee3554602fe068eed0c90b075958c1 

Diff: https://reviews.apache.org/r/24340/diff/


Testing
-------


Thanks,

Dong Lin