One more thought after I did some more digging on the related PR.
Should we do the same thing for `windowed.inner.serde.class`?
Both config belong to windowed serdes (which KS provide) but the KS code
itself does never use them (and in fact, disallows to use them and would
throw an error is used). Both are intended for plain consumer use cases
for which the window serdes are used.
The question to me is, should we add them back somewhere else? It does
not really belong into `ConsumerConfig` either, but maybe we could add
them to the corresponding serde or (de)serialize classes?
-Matthias
On 2/21/24 2:41 PM, Matthias J. Sax wrote:
Thanks for the KIP. Sounds like a nice cleanup.
window.size.ms is not a true KafkaStreams config, and results in an
error when set from a KStreams application
What error?
Given that the configs is used by `TimeWindowedDeserializer` I am
wondering if we should additionally add
public class TimeWindowedDeserializer {
public static final String WINDOW_SIZE_MS_CONFIG = "window.size.ms";
}
-Matthias
On 2/15/24 6:32 AM, Lucia Cerchie wrote:
Hey everyone,
I'd like to discuss KIP-1020
<https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=290982804>,
which would move to deprecate `window.size.ms` in `StreamsConfig` since `
window.size.ms` is a client config.
Thanks in advance!
Lucia Cerchie
