Hi Omnia, Thanks for this KIP.
11. These seem to me to be small misspellings, please double-check: s/MM2 main features/MM2's main features s/syncing consumer group offset/syncing consumer group offsets s/relays/relies s/recored's offset/recorded offsets s/clusters without need for/clusters without the need for s/creating internal topic./creating an internal topic. s/This KIP propose that/This KIP proposes that 12. The use of the word "customers" seems a bit odd to me in this context. Did you perhaps mean one of "use-cases", "users" or "operators"? 13. "They still left with part#1 of this feature which add cost to the progress of their replication." I'm unsure what this means. Do you mean to say that MirrorCheckpointConnector is disabled but MirrorSourceConnector is not? Could you also clarify where the additional cost comes from? 14. This is probably more ignorance of mine: it doesn't seem obvious in the KIP how increasing offset.lag.max to INT_MAX helps reduce latency. I'm guessing it's related to KAFKA-14610 but after having a look I still couldn't understand why. -- Igor On Wed, Apr 17, 2024, at 3:22 PM, Omnia Ibrahim wrote: > Thanks Chris and Mickael for the votes. > Can I please get one last +1 binding vote please? > > Thanks > Omnia > > > On 12 Apr 2024, at 13:21, Chris Egerton <fearthecel...@gmail.com> wrote: > > > > +1 (binding), thanks Omnia! > > > > On Fri, Apr 12, 2024, 03:46 Mickael Maison <mickael.mai...@gmail.com> wrote: > > > >> Hi Omnia, > >> > >> +1 (binding), thanks for the KIP! > >> > >> Mickael > >> > >> On Fri, Apr 12, 2024 at 9:01 AM Omnia Ibrahim <o.g.h.ibra...@gmail.com> > >> wrote: > >>> > >>> Hi everyone, I would like to start a voting thread for KIP-1031: Control > >> offset translation in MirrorSourceConnector > >> https://cwiki.apache.org/confluence/display/KAFKA/KIP-1031%3A+Control+offset+translation+in+MirrorSourceConnector > >>> > >>> For comments or feedback please check the discussion thread here > >> https://lists.apache.org/thread/ym6zr0wrhglft5c000x9c8ych098s7h6 > >>> > >>> Thanks > >>> Omnia > >>> > >> > >
