[ 
https://issues.apache.org/jira/browse/KAFKA-1481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14094147#comment-14094147
 ] 

Jun Rao commented on KAFKA-1481:
--------------------------------

The name of "FetchQueueSize" is of the following format. If the clientId is not 
explicitly specified, the groupId will be used. So if you know the clientId, 
you can parse the rest of the string. You probably don't need to figure out 
every part of the mbean name. The most important ones are clientId, groupId and 
topic. 

config.clientId + "-" + config.groupId + "-" + topicThreadId._1 + "-" + 
topicThreadId._2 + "-FetchQueueSize"

Joe,

I am not sure having a config is necessarily better. If we want to fix the 
mbean names, I'd rather that we fix them once into the end state that we want, 
instead of patching little by little and changing the names multiple times.

> Stop using dashes AND underscores as separators in MBean names
> --------------------------------------------------------------
>
>                 Key: KAFKA-1481
>                 URL: https://issues.apache.org/jira/browse/KAFKA-1481
>             Project: Kafka
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 0.8.1.1
>            Reporter: Otis Gospodnetic
>              Labels: patch
>             Fix For: 0.8.2
>
>         Attachments: KAFKA-1481_2014-06-06_13-06-35.patch
>
>
> MBeans should not use dashes or underscores as separators because these 
> characters are allowed in hostnames, topics, group and consumer IDs, etc., 
> and these are embedded in MBeans names making it impossible to parse out 
> individual bits from MBeans.
> Perhaps a pipe character should be used to avoid the conflict. 
> This looks like a major blocker because it means nobody can write Kafka 0.8.x 
> monitoring tools unless they are doing it for themselves AND do not use 
> dashes AND do not use underscores.
> See: http://search-hadoop.com/m/4TaT4lonIW



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to