Hi, Ivan, Thanks for the reply. KafkaShareConsumer doesn't take all configuration values from KafkaConsumer. So, we need to make a note that this new config will be part of KafkaShareConsumer too.
Jun On Wed, May 22, 2024 at 9:45 AM Ivan Yurchenko <i...@ivanyu.me> wrote: > Hi! > > I had a look at the KIP-932, and it seems KafkaShareConsumer is to be > configured the same way as the normal consumer using key-value props. As I > understand correctly, no adaptation is needed for it to benefit from > KIP-899? > > Meanwhile, the PR [1] is open for review. If there are comments that > require changes, we can address them in the PR or in case it's already > merged, afterwards. > > Best, > Ivan > > [1] https://github.com/apache/kafka/pull/13277 > > On Thu, May 16, 2024, at 01:52, Jun Rao wrote: > > Hi, Ivan, > > > > You are right. StreamsConfigs can take all existing consumer configs, > with > > or without prefixes. So, we don't need to add the new config to > > StreamsConfig explicitly. > > > > For KIP-932, it says for each new consumer config, we need to determine > > whether it should be added to ShareConsumer config too. > > > > Thanks, > > > > Jun > > > > On Wed, May 15, 2024 at 12:16 PM Ivan Yurchenko <i...@ivanyu.me> wrote: > > > > > Hi Jun, > > > > > > Thank you for you comment. I was thinking that this > > > `metadata.recovery.strategy` could be passed to the relevant consumer > in > > > streams using the `restore.consumer.` prefix. I that what you meant or > I > > > misunderstand? > > > As for the KIP-932, I'll have a closer look. > > > > > > Ivan > > > > > > > > > On Wed, May 15, 2024, at 20:14, Jun Rao wrote: > > > > Hi, Ivan, > > > > > > > > Thanks for the KIP. +1 > > > > > > > > Just a minor comment. Should we add metadata.recovery.strategy to the > > > > Streams and the newly introduced ShareConsumer (KIP-932) too? > > > > > > > > Jun > > > > > > > > On Wed, May 8, 2024 at 11:35 AM Manikumar <manikumar.re...@gmail.com > > > > > wrote: > > > > > > > > > Thanks for the KIP. > > > > > > > > > > +1 (binding). > > > > > > > > > > On Wed, Apr 17, 2024 at 7:50 PM Omnia Ibrahim < > o.g.h.ibra...@gmail.com > > > > > > > > > wrote: > > > > > > > > > > > > Hi Ivan, > > > > > > Thanks for the KIP this is a very nice feature to have. > > > > > > +1(non-binding) > > > > > > Omnia > > > > > > > On 15 Apr 2024, at 14:33, Andrew Schofield < > > > andrew_schofi...@live.com> > > > > > wrote: > > > > > > > > > > > > > > Thanks for the KIP > > > > > > > > > > > > > > +1 (non-binding) > > > > > > > > > > > > > > Andrew > > > > > > > > > > > > > >> On 15 Apr 2024, at 14:16, Chris Egerton > <chr...@aiven.io.INVALID> > > > > > wrote: > > > > > > >> > > > > > > >> Hi Ivan, > > > > > > >> > > > > > > >> Thanks for the KIP. After the recent changes, this LGTM. +1 > > > (binding) > > > > > > >> > > > > > > >> Cheers, > > > > > > >> > > > > > > >> Chris > > > > > > >> > > > > > > >> On Wed, Aug 2, 2023 at 12:15 AM Ivan Yurchenko < > > > > > ivan0yurche...@gmail.com> > > > > > > >> wrote: > > > > > > >> > > > > > > >>> Hello, > > > > > > >>> > > > > > > >>> The discussion [1] for KIP-899 [2] has been open for quite > some > > > > > time. I'd > > > > > > >>> like to put the KIP up for a vote. > > > > > > >>> > > > > > > >>> Best, > > > > > > >>> Ivan > > > > > > >>> > > > > > > >>> [1] > > > https://lists.apache.org/thread/m0ncbmfxs5m87sszby2jbmtjx2bdpcdl > > > > > > >>> [2] > > > > > > >>> > > > > > > >>> > > > > > > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-899%3A+Allow+producer+and+consumer+clients+to+rebootstrap > > > > > > >>> > > > > > > > > > > > > > > > > > > > > > > > > > > > >
