-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23567/#review50663
-----------------------------------------------------------

Ship it!



core/src/main/scala/kafka/api/TransactionRequest.scala
<https://reviews.apache.org/r/23567/#comment88514>

    It would help to have comments here describing each type's role.


- Joel Koshy


On Aug. 9, 2014, 4:21 a.m., Dong Lin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23567/
> -----------------------------------------------------------
> 
> (Updated Aug. 9, 2014, 4:21 a.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-1522
>     https://issues.apache.org/jira/browse/KAFKA-1522
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> KAFKA-1522; Tansactional messaging request/response definitions
> 
> 
> Diffs
> -----
> 
>   core/src/main/scala/kafka/api/RequestKeys.scala 
> c24c0345feedc7b9e2e9f40af11bfa1b8d328c43 
>   core/src/main/scala/kafka/api/TransactionRequest.scala PRE-CREATION 
>   core/src/main/scala/kafka/api/TransactionResponse.scala PRE-CREATION 
>   core/src/main/scala/kafka/api/TxCoordinatorMetadataRequest.scala 
> PRE-CREATION 
>   core/src/main/scala/kafka/api/TxCoordinatorMetadataResponse.scala 
> PRE-CREATION 
>   core/src/main/scala/kafka/common/ErrorMapping.scala 
> 5559d26ba2b96059f719754a351fa4598ca8a70b 
>   core/src/test/scala/unit/kafka/api/RequestResponseSerializationTest.scala 
> cd16ced5465d098be7a60498326b2a98c248f343 
> 
> Diff: https://reviews.apache.org/r/23567/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dong Lin
> 
>

Reply via email to