[
https://issues.apache.org/jira/browse/KAFKA-873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14099942#comment-14099942
]
Viktor Taranenko commented on KAFKA-873:
----------------------------------------
[~nehanarkhede]
There is a FAQ on Curator and section about ZKClient
https://github.com/Netflix/curator/wiki/FAQ#why-not-use-zkclient
Curator also has async api
http://curator.apache.org/apidocs/index.html?org/apache/curator/framework/api/Backgroundable.html
I'm new to Kafka and don't know if it can take an advantage of parallel
requests to zookeeper. But I saw in ZkUtils class serial blocking calls in
loop to Zookeeper.
Like
{code}
def getAllBrokersInCluster(zkClient: ZkClient): Seq[Broker] = {
val brokerIds = ZkUtils.getChildrenParentMayNotExist(zkClient,
ZkUtils.BrokerIdsPath).sorted
brokerIds.map(_.toInt).map(getBrokerInfo(zkClient,
_)).filter(_.isDefined).map(_.get)
}
{code}
So in combination with Scala Futures there might be field for improvement.
If there is any interest in trying it, I can prepare the changeset
Cheers
> Consider replacing zkclient with curator (with zkclient-bridge)
> ---------------------------------------------------------------
>
> Key: KAFKA-873
> URL: https://issues.apache.org/jira/browse/KAFKA-873
> Project: Kafka
> Issue Type: Improvement
> Affects Versions: 0.8.0
> Reporter: Scott Clasen
>
> If zkclient was replaced with curator and curator-x-zkclient-bridge it would
> be initially a drop-in replacement
> https://github.com/Netflix/curator/wiki/ZKClient-Bridge
> With the addition of a few more props to ZkConfig, and a bit of code this
> would open up the possibility of using ACLs in zookeeper (which arent
> supported directly by zkclient), as well as integrating with netflix
> exhibitor for those of us using that.
> Looks like KafkaZookeeperClient needs some love anyhow...
--
This message was sent by Atlassian JIRA
(v6.2#6252)
