Thanks Bill.
Given that Admin client does currently not implement sending metric, the
change to disable it by default for Admin client does make sense to me.
It might be too much overhead to open/close connection if there are not
metrics to be sent, and for developers using the new API to send custom
metrics they can enable it.
-Matthias
On 9/27/24 3:32 PM, Bill Bejeck wrote:
Hi All,
Just a quick update on KIP-1076. Due to the ad hoc connections made by the
`AdminClient` I've updated the KIP to state that the default value of the
`AdminClient.ENABLE_METRICS_PUSH_CONFIG` will be set to false.
I expect this minor change to be non-controversial, but it should be noted
in the discussion.
Thanks,
Bill
On Fri, Sep 6, 2024 at 12:59 PM Bill Bejeck <bbej...@gmail.com> wrote:
Hi All,
The vote is now closed.
The KIP has been accepted with 4 binding votes from Lucas, Matthias,
Sophie, and Bruno and 2 non-binding votes from Andrew and Apoorv.
Thanks to everyone for participating!
Regards,
Bill
On Thu, Sep 5, 2024 at 10:58 AM Bruno Cadonna <cado...@apache.org> wrote:
Thanks for the KIP!
+1 (binding)
Best,
Bruno
On 9/4/24 11:29 PM, Sophie Blee-Goldman wrote:
Thanks for the KIP Bill
+1 (binding)
On Tue, Sep 3, 2024 at 1:54 PM Apoorv Mittal <apoorvmitta...@gmail.com>
wrote:
Thanks for the KIP, looking forward to it.
+1 (non-binding)
Regards,
Apoorv Mittal
On Tue, Sep 3, 2024 at 9:00 PM Matthias J. Sax <mj...@apache.org>
wrote:
+1 (binding)
On 9/3/24 8:56 AM, Andrew Schofield wrote:
Thanks for the KIP. +1 (non-binding)
Andrew
________________________________
From: Lucas Brutschy <lbruts...@confluent.io.INVALID>
Sent: 03 September 2024 16:02
To: dev@kafka.apache.org <dev@kafka.apache.org>
Subject: Re: [VOTE] KIP-1076: Metrics for client applications a
KIP-714
extension
Hi Bill,
thanks for the KIP! +1 (binding)
Lucas
On Tue, Sep 3, 2024 at 4:49 PM Bill Bejeck <bbej...@apache.org>
wrote:
Hi All,
I'd like to call for a vote on KIP-1076
<
https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fcwiki.apache.org%2Fconfluence%2Fdisplay%2FKAFKA%2FKIP-1076%253A%2B%2BMetrics%2Bfor%2Bclient%2Bapplications%2BKIP-714%2Bextension&data=05%7C02%7C%7C0ba83dece6894a4126b508dccc29a7ed%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C638609726517807511%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C0%7C%7C%7C&sdata=DqHjamMzaj4gwSvGwZv89CPCONXxNrB%2BNyhte2oJpKE%3D&reserved=0
<
https://cwiki.apache.org/confluence/display/KAFKA/KIP-1076%3A++Metrics+for+client+applications+KIP-714+extension
(discussion can be found here
<
https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.apache.org%2Fthread%2F9yf4w9qy0zr7qy9ftjcft0s32w32b891&data=05%7C02%7C%7C0ba83dece6894a4126b508dccc29a7ed%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C638609726517819714%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C0%7C%7C%7C&sdata=hP3ykAMVOAb8WigLK92GDLl6pYCty4AgngZrsEDQLhQ%3D&reserved=0
<https://lists.apache.org/thread/9yf4w9qy0zr7qy9ftjcft0s32w32b891>>)
-Bill
