> On Aug. 22, 2014, 8:50 p.m., Guozhang Wang wrote: > > clients/src/main/java/org/apache/kafka/common/requests/MetadataResponse.java, > > line 121 > > <https://reviews.apache.org/r/24992/diff/2/?file=667650#file667650line121> > > > > Is this possilbe that the reponse can also contain other exceptions > > like UNKNOWN_TOPIC_OR_PARTITION now or in the future? If yes we also need > > to exlude them also.
I think the UNKNOWN_TOPIC_OR_PARTITION will be captured in topic error code. From what I learned from source code, currently metadata response only returns LEADER_NOT_AVAILABLE or REPLICA_NOT_AVAILABLE as parition error code. - Dong ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24992/#review51316 ----------------------------------------------------------- On Aug. 22, 2014, 8:04 p.m., Dong Lin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24992/ > ----------------------------------------------------------- > > (Updated Aug. 22, 2014, 8:04 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1609 > https://issues.apache.org/jira/browse/KAFKA-1609 > > > Repository: kafka > > > Description > ------- > > KAFKA-1609; New producer metadata response handling should only exclude a > PartitionInfo when its error is LEADER_NOT_AVAILABLE > > > Diffs > ----- > > > clients/src/main/java/org/apache/kafka/common/requests/MetadataResponse.java > 7d90fceffd4a92460c616f8bacd78057a38a3c16 > > Diff: https://reviews.apache.org/r/24992/diff/ > > > Testing > ------- > > > Thanks, > > Dong Lin > >
