[ 
https://issues.apache.org/jira/browse/KAFKA-1558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14130611#comment-14130611
 ] 

Neha Narkhede commented on KAFKA-1558:
--------------------------------------

bq. I think what we need now is to test deleteTopic under failure modes - 
leader election, partition reassignment, etc.

Yes, it would help if someone who has cycles can take this up and basically try 
to break delete topic under various failure scenarios. Currently, the approach 
to fixing delete topic is a little ad-hoc.

> AdminUtils.deleteTopic does not work
> ------------------------------------
>
>                 Key: KAFKA-1558
>                 URL: https://issues.apache.org/jira/browse/KAFKA-1558
>             Project: Kafka
>          Issue Type: Bug
>    Affects Versions: 0.8.1.1
>            Reporter: Henning Schmiedehausen
>            Assignee: Sriharsha Chintalapani
>            Priority: Blocker
>             Fix For: 0.8.2
>
>
> the AdminUtils:.deleteTopic method is implemented as
> {code}
>     def deleteTopic(zkClient: ZkClient, topic: String) {
>         ZkUtils.createPersistentPath(zkClient, 
> ZkUtils.getDeleteTopicPath(topic))
>     }
> {code}
> but the DeleteTopicCommand actually does
> {code}
>     zkClient = new ZkClient(zkConnect, 30000, 30000, ZKStringSerializer)
>     zkClient.deleteRecursive(ZkUtils.getTopicPath(topic))
> {code}
> so I guess, that the 'createPersistentPath' above should actually be 
> {code}
>     def deleteTopic(zkClient: ZkClient, topic: String) {
>         ZkUtils.deletePathRecursive(zkClient, ZkUtils.getTopicPath(topic))
>     }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to