Hi Kirk and Andrew. Thanks so much for the feedback. I agree that consistency is better for now, but once this is done, I can follow up with adding SubscriptionPattern support to both ConsumerPerformance and ConsoleConsumer tools (I guess a KIP is not needed in this case).
On Tue, Jul 15, 2025 at 2:33 PM Andrew Schofield <andrew_schofield_j...@outlook.com> wrote: > > Hi Fede (and Kirk), > Thanks for the KIP. A comment on Kirk's comment :) > > KT01: This is certainly an interesting question. I think we need a small KIP > for kafka-console-consumer.sh > because it only supports Consumer.subscribe(Pattern), and not the newer > KIP-848 > Consumer.subscribe(SubscriptionPattern). I think KIP-1192 is consistent with > the current > state of kafka-console-consumer.sh, and it's a nice addition. > > Thanks, > Andrew > ________________________________________ > From: Kirk True <k...@kirktrue.pro> > Sent: 15 July 2025 01:48 > To: dev@kafka.apache.org <dev@kafka.apache.org> > Subject: Re: [DISCUSS] KIP-1192: Add include argument to ConsumerPerformance > tool > > Hi Fede, > > Thanks for the KIP! > > Question: > > KT01: Does this argument support the Gogle RE2/J dialect that's used with the > new Consumer.subscribe(SubscriptionPattern) API? That was added in KIP-848 as > part of a transition from the java.util.regex.Pattern regular expression > dialect to Google’s RE2/J. > > Thanks, > Kirk > > On Sun, Jul 13, 2025, at 11:28 PM, Federico Valeri wrote: > > Hello everyone, I would like to propose a small improvement to the > > consumer performance tool that has been useful in my own tests: > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-1192%3A+Add+include+argument+to+ConsumerPerformance+tool > > > > Thanks > > Fede > >
